chore: update to go 1.26

.github/workflows/go.yml

@@ -16,8 +16,16 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.22'
+          go-version: '1.26'
 
+      - name: Test if go.mod and go.sum are up to date
+        run: |
+          go mod tidy
+          git diff --exit-code
+      - name: Check if conformant to go fix
+        run: |
+          go fix ./...
+          git diff --exit-code
       - name: Run linters
         run: go tool golangci-lint run
 

docker/admin/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.24-alpine as build
+FROM golang:1.26-alpine as build
 
 ENV GO111MODULE=on \
     CGO_ENABLED=0 \

docker/api/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.24-alpine as build
+FROM golang:1.26-alpine as build
 
 ENV GO111MODULE=on \
     CGO_ENABLED=0 \

docker/websocket/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.24-alpine as build
+FROM golang:1.26-alpine as build
 
 ENV GO111MODULE=on \
     CGO_ENABLED=0 \

e2e-tests/browser_extension/browser_extension_test.go

@@ -91,10 +91,10 @@ func createBrowserExtension(t *testing.T, name string) *http.Response {
 
 	pubKey := crypto.PublicKeyToBase64(keyPair.PublicKey)
 
-	payload := []byte(fmt.Sprintf(
+	payload := fmt.Appendf(nil,
 		`{"name":"%s","browser_name":"go-browser","browser_version":"0.1","public_key":"%s"}`,
 		name,
-		pubKey))
+		pubKey)
 
 	return e2e_tests.DoAPIRequest(t, "/browser_extensions", http.MethodPost, payload, nil)
 }

e2e-tests/helpers.go

@@ -14,7 +14,7 @@ func CreateDevice(t *testing.T, name, fcmToken string) (*DeviceResponse, string)
 	keyPair := crypto.GenerateKeyPair(2048)
 	devicePubKey := crypto.PublicKeyToBase64(keyPair.PublicKey)
 
-	payload := []byte(fmt.Sprintf(`{"name":"%s","platform":"android","fcm_token":"%s"}`, name, fcmToken))
+	payload := fmt.Appendf(nil, `{"name":"%s","platform":"android","fcm_token":"%s"}`, name, fcmToken)
 
 	device := new(DeviceResponse)
 
@@ -30,10 +30,10 @@ func CreateBrowserExtension(t *testing.T, name string) *BrowserExtensionResponse
 
 	pubKey := crypto.PublicKeyToBase64(keyPair.PublicKey)
 
-	payload := []byte(
-		fmt.Sprintf(
+	payload :=
+		fmt.Appendf(nil,
 			`{"name":"%s","browser_name":"go-browser","browser_version":"0.1","public_key":"%s"}`,
-			name, pubKey))
+			name, pubKey)
 
 	browserExt := new(BrowserExtensionResponse)
 
@@ -45,9 +45,9 @@ func CreateBrowserExtension(t *testing.T, name string) *BrowserExtensionResponse
 func CreateBrowserExtensionWithPublicKey(t *testing.T, name, publicKey string) *BrowserExtensionResponse {
 	t.Helper()
 
-	payload := []byte(
-		fmt.Sprintf(`{"name":"%s","browser_name":"go-browser","browser_version":"0.1","public_key":"%s"}`,
-			name, publicKey))
+	payload :=
+		fmt.Appendf(nil, `{"name":"%s","browser_name":"go-browser","browser_version":"0.1","public_key":"%s"}`,
+			name, publicKey)
 
 	browserExt := new(BrowserExtensionResponse)
 
@@ -100,7 +100,7 @@ func Request2FaToken(t *testing.T, domain, extensionId string) *AuthTokenRequest
 
 	var response *AuthTokenRequestResponse
 
-	payload := []byte(fmt.Sprintf(`{"domain":"%s"}`, domain))
+	payload := fmt.Appendf(nil, `{"domain":"%s"}`, domain)
 
 	DoAPISuccessPost(t, "browser_extensions/"+extensionId+"/commands/request_2fa_token", payload, &response)
 

e2e-tests/http.go

@@ -30,13 +30,13 @@ func (a *BasicAuth) Header() string {
 	return "Basic " + base64.StdEncoding.EncodeToString([]byte(base))
 }
 
-func DoAPISuccessPost(t *testing.T, uri string, payload []byte, resp interface{}) {
+func DoAPISuccessPost(t *testing.T, uri string, payload []byte, resp any) {
 	t.Helper()
 	response := doRequest(t, apiRawURL, uri, http.MethodPost, payload, resp)
 	require.Equal(t, http.StatusOK, response.StatusCode)
 }
 
-func DoAdminAPISuccessPost(t *testing.T, uri string, payload []byte, resp interface{}) {
+func DoAdminAPISuccessPost(t *testing.T, uri string, payload []byte, resp any) {
 	t.Helper()
 	response := doRequest(t, adminRawURL, uri, http.MethodPost, payload, resp)
 	bb, err := io.ReadAll(response.Body)
@@ -45,29 +45,29 @@ func DoAdminAPISuccessPost(t *testing.T, uri string, payload []byte, resp interf
 	require.Equal(t, http.StatusOK, response.StatusCode, "invalid status code, response payload is: %q", string(bb))
 }
 
-func DoAdminPostAndAssertCode(t *testing.T, expCode int, uri string, payload []byte, resp interface{}) {
+func DoAdminPostAndAssertCode(t *testing.T, expCode int, uri string, payload []byte, resp any) {
 	t.Helper()
 	response := doRequest(t, adminRawURL, uri, http.MethodPost, payload, resp)
 	require.Equal(t, expCode, response.StatusCode)
 }
 
-func DoAPIPostAndAssertCode(t *testing.T, expCode int, uri string, payload []byte, resp interface{}) {
+func DoAPIPostAndAssertCode(t *testing.T, expCode int, uri string, payload []byte, resp any) {
 	t.Helper()
 	response := doRequest(t, apiRawURL, uri, http.MethodPost, payload, resp)
 	require.Equal(t, expCode, response.StatusCode)
 }
 
-func DoAPIRequest(t *testing.T, uri, method string, payload []byte, resp interface{}) *http.Response {
+func DoAPIRequest(t *testing.T, uri, method string, payload []byte, resp any) *http.Response {
 	t.Helper()
 	return doRequest(t, apiRawURL, uri, method, payload, resp)
 }
 
-func DoAdminRequest(t *testing.T, uri, method string, payload []byte, resp interface{}) *http.Response {
+func DoAdminRequest(t *testing.T, uri, method string, payload []byte, resp any) *http.Response {
 	t.Helper()
 	return doRequest(t, apiRawURL, uri, method, payload, resp)
 }
 
-func DoAdminSuccessPut(t *testing.T, uri string, payload []byte, resp interface{}) {
+func DoAdminSuccessPut(t *testing.T, uri string, payload []byte, resp any) {
 	t.Helper()
 	response := doRequest(t, adminRawURL, uri, http.MethodPut, payload, resp)
 	bb, err := io.ReadAll(response.Body)
@@ -76,26 +76,26 @@ func DoAdminSuccessPut(t *testing.T, uri string, payload []byte, resp interface{
 	require.Equal(t, http.StatusOK, response.StatusCode, "invalid status code, response payload is: %q", string(bb))
 }
 
-func DoAPISuccessPut(t *testing.T, uri string, payload []byte, resp interface{}) {
+func DoAPISuccessPut(t *testing.T, uri string, payload []byte, resp any) {
 	t.Helper()
 
 	response := doRequest(t, apiRawURL, uri, http.MethodPut, payload, resp)
 	require.Equal(t, http.StatusOK, response.StatusCode)
 }
 
-func DoAPISuccessGet(t *testing.T, uri string, resp interface{}) {
+func DoAPISuccessGet(t *testing.T, uri string, resp any) {
 	t.Helper()
 
 	response := doRequest(t, apiRawURL, uri, http.MethodGet, nil /*payload*/, resp)
 	require.Equal(t, http.StatusOK, response.StatusCode)
 }
 
-func DoAPIGet(t *testing.T, uri string, resp interface{}) *http.Response {
+func DoAPIGet(t *testing.T, uri string, resp any) *http.Response {
 	t.Helper()
 	return doRequest(t, apiRawURL, uri, http.MethodGet, nil /*payload*/, resp)
 }
 
-func DoAdminSuccessGet(t *testing.T, uri string, resp interface{}) {
+func DoAdminSuccessGet(t *testing.T, uri string, resp any) {
 	t.Helper()
 	response := doRequest(t, adminRawURL, uri, http.MethodGet, nil /*payload*/, resp)
 	require.Equal(t, http.StatusOK, response.StatusCode)
@@ -113,7 +113,7 @@ func DoAPISuccessDelete(t *testing.T, uri string) {
 	require.Equal(t, http.StatusOK, response.StatusCode)
 }
 
-func doRequest(t *testing.T, base, uri, method string, payload []byte, resp interface{}) *http.Response {
+func doRequest(t *testing.T, base, uri, method string, payload []byte, resp any) *http.Response {
 	t.Helper()
 	baseURL, err := url.Parse(base)
 	require.NoError(t, err)

e2e-tests/icons/icons_requests_test.go

@@ -3,7 +3,7 @@ package tests
 import (
 	"encoding/base64"
 	"encoding/json"
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/jaswdr/faker"
@@ -38,7 +38,7 @@ func (s *IconsRequestsTestSuite) TestCreateIconRequest() {
 func (s *IconsRequestsTestSuite) TestCreateIconRequestWithNotAllowedIconDimensions() {
 	img := faker.New().Image().Image(120, 60)
 
-	pngImg, err := ioutil.ReadFile(img.Name())
+	pngImg, err := os.ReadFile(img.Name())
 
 	if err != nil {
 		s.T().Error(err)
@@ -157,7 +157,7 @@ func createIconRequest(t *testing.T, serviceName string) *queries.IconRequestPre
 
 	img := faker.New().Image().Image(120, 120)
 
-	pngImg, err := ioutil.ReadFile(img.Name())
+	pngImg, err := os.ReadFile(img.Name())
 
 	if err != nil {
 		t.Error(err)

e2e-tests/icons/icons_test.go

@@ -2,7 +2,8 @@ package tests
 
 import (
 	"encoding/base64"
-	"io/ioutil"
+	"os"
+
 	"testing"
 
 	"github.com/jaswdr/faker"
@@ -16,7 +17,7 @@ func createIcon(t *testing.T) *query.IconPresenter {
 	t.Helper()
 	img := faker.New().Image().Image(120, 120)
 
-	pngImg, err := ioutil.ReadFile(img.Name())
+	pngImg, err := os.ReadFile(img.Name())
 
 	if err != nil {
 		t.Error(err)

e2e-tests/icons/web_services_dump_test.go

@@ -38,15 +38,15 @@ func createWebService(t *testing.T) *webServiceResponse {
 	iconsCollection := createIconsCollection(t)
 
 	id := fmt.Sprintf("service-%d", rand.Int()) // nolint:gosec // only for tests
-	payload := []byte(fmt.Sprintf(`
+	payload := fmt.Appendf(nil, `
 		{
 			"name":"%s", 
 			"description":"another",
 			"issuers":["facebook", "m.facebook"],
 			"tags":["shitbook"],
 			"icons_collections":["%s"]
 		}
-	`, id, iconsCollection.Id))
+	`, id, iconsCollection.Id)
 
 	var webService *webServiceResponse
 

e2e-tests/mobile/mobile_device_extension_test.go

@@ -99,10 +99,10 @@ func (s *MobileDeviceExtensionTestSuite) TestExtensionHasAlreadyBeenConnected()
 	device, devicePubKey := e2e_tests.CreateDevice(s.T(), "go-test-device", "some-device-id")
 	e2e_tests.PairDeviceWithBrowserExtension(s.T(), devicePubKey, extension, device)
 
-	payload := []byte(fmt.Sprintf(`{"extension_id":"%s","device_name":"%s","device_public_key":"%s"}`,
+	payload := fmt.Appendf(nil, `{"extension_id":"%s","device_name":"%s","device_public_key":"%s"}`,
 		extension.Id,
 		device.Name,
-		devicePubKey))
+		devicePubKey)
 
 	e2e_tests.DoAPIPostAndAssertCode(s.T(),
 		409,

e2e-tests/mobile/mobile_device_test.go

@@ -49,6 +49,6 @@ func (s *MobileDeviceTestSuite) TestCreateMobileDevice() {
 
 func createDevice(t *testing.T, name, fcmToken string) *http.Response {
 	t.Helper()
-	payload := []byte(fmt.Sprintf(`{"name":"%s","platform":"android","fcm_token":"%s"}`, name, fcmToken))
+	payload := fmt.Appendf(nil, `{"name":"%s","platform":"android","fcm_token":"%s"}`, name, fcmToken)
 	return e2e_tests.DoAPIRequest(t, "mobile/devices", http.MethodPost, payload, nil)
 }

e2e-tests/mobile/mobile_security_test.go

@@ -20,7 +20,7 @@ func Test_MobileApiBandwidthAbuse(t *testing.T) {
 
 	eg := errgroup.Group{}
 	eg.SetLimit(noOfWorkers)
-	for i := 0; i < noOfRequest; i++ {
+	for range noOfRequest {
 		eg.Go(func() error {
 			resp := e2e_tests.DoAPIGet(t, "/mobile/devices/"+someId.String()+"/browser_extensions", nil)
 
@@ -58,7 +58,7 @@ func Test_BrowserExtensionApiBandwidthAbuse(t *testing.T) {
 
 	eg := errgroup.Group{}
 	eg.SetLimit(noOfWorkers)
-	for i := 0; i < noOfRequest; i++ {
+	for range noOfRequest {
 		eg.Go(func() error {
 			resp := e2e_tests.DoAPIGet(t, "/browser_extensions/"+someId.String(), nil)
 

e2e-tests/support/mobile_debug_logs_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"mime/multipart"
 	"net/http"
 	"strings"
@@ -74,10 +73,10 @@ func (s *DebugLogsAuditTestSuite) TestFulfillDebugLogsAuditClaim() {
 	s.Require().NoError(err)
 	s.Equal(200, response.StatusCode)
 
-	reqB, _ := ioutil.ReadAll(body)
+	reqB, _ := io.ReadAll(body)
 	s.T().Log(string(reqB))
 
-	rawBody, _ := ioutil.ReadAll(response.Body)
+	rawBody, _ := io.ReadAll(response.Body)
 
 	s.T().Log(string(rawBody))
 }

go.mod

@@ -1,6 +1,6 @@
 module github.com/twofas/2fas-server
 
-go 1.24.0
+go 1.26.0
 
 require (
 	firebase.google.com/go/v4 v4.15.2

internal/api/app.go

@@ -58,7 +58,7 @@ func NewApplication(applicationName string, config config.Configuration) (*Appli
 		pushClient = push.NewFakePushClient()
 	} else {
 		sess, err := session.NewSession(&aws.Config{
-			Region: aws.String(config.Aws.Region),
+			Region: new(config.Aws.Region),
 		})
 		if err != nil {
 			return nil, fmt.Errorf("failed to create aws session: %w", err)

internal/api/browser_extension/app/command/request_2fa_token.go

@@ -84,7 +84,7 @@ func (h *Request2FaTokenHandler) Handle(
 		return nil, err
 	}
 
-	data := map[string]interface{}{
+	data := map[string]any{
 		"extension_id": extId.String(),
 		"request_id":   cmd.Id,
 		"domain":       cmd.Domain,
@@ -113,7 +113,7 @@ func (h *Request2FaTokenHandler) sendPush(
 	ctx context.Context,
 	log logging.FieldLogger,
 	device *domain.ExtensionDevice,
-	data map[string]interface{}) PushNotificationStatus {
+	data map[string]any) PushNotificationStatus {
 	if device.FcmToken == "" {
 		log.Info("Cannot send push notification, missing FCM token")
 		return PushNotificationStatusNoFCM
@@ -157,7 +157,7 @@ func (h *Request2FaTokenHandler) findPairedDevices(
 
 func (h *Request2FaTokenHandler) sendNotification(ctx context.Context,
 	device *domain.ExtensionDevice,
-	data map[string]interface{}) error {
+	data map[string]any) error {
 	var notification *messaging.Message
 
 	switch device.Platform {
@@ -176,7 +176,7 @@ func (h *Request2FaTokenHandler) sendNotification(ctx context.Context,
 	)
 }
 
-func createPushNotificationForIos(token string, data map[string]interface{}) *messaging.Message {
+func createPushNotificationForIos(token string, data map[string]any) *messaging.Message {
 	ttl := time.Now().Add(tokenPushNotificationTtl)
 
 	return &messaging.Message{
@@ -200,7 +200,7 @@ func createPushNotificationForIos(token string, data map[string]interface{}) *me
 	}
 }
 
-func createPushNotificationForAndroid(token string, data map[string]interface{}) *messaging.Message {
+func createPushNotificationForAndroid(token string, data map[string]any) *messaging.Message {
 	androidData := make(map[string]string, len(data))
 
 	for key, value := range data {

internal/api/health/ports/http.go

@@ -114,7 +114,7 @@ func (r *RoutesHandler) RedisInfo(c *gin.Context) {
 
 func (r *RoutesHandler) GetApplicationConfiguration(c *gin.Context) {
 	sess, err := session.NewSession(&aws.Config{
-		Region: aws.String(config.Config.Aws.Region),
+		Region: new(config.Config.Aws.Region),
 	})
 	if err != nil {
 		// This is an internal endpoint, so we can return the error as is.

internal/api/support/app/command/create_debug_log_audit.go

@@ -3,7 +3,8 @@ package command
 import (
 	"bytes"
 	"errors"
-	"io/ioutil"
+	"io"
+
 	"mime/multipart"
 	"path/filepath"
 
@@ -58,7 +59,7 @@ func (h *CreateDebugLogsAuditHandler) Handle(command *CreateDebugLogsAudit) erro
 		return err
 	}
 
-	file, _ := ioutil.ReadAll(logsFile)
+	file, _ := io.ReadAll(logsFile)
 
 	logsFileReader := bytes.NewReader(file)