Repository navigation
fix: treat github/* as a verified first-party publisher - #1
Merged
Merged
Conversation
…ty publisher GitHub's own `github/*` org (e.g. `github/codeql-action`) is documented in the README as a verified publisher, but `check_verified_publisher()` only hardcoded the `actions` namespace. Because GitHub does not badge its own org as a third-party "partner organization" on the Marketplace, the scrape-based fallback could never confirm `github/*`, producing spurious "Not from verified publisher" failures for first-party actions like CodeQL. Add `github` alongside `actions` in the always-verified branch, matching the existing precedent (v1.4.2) and the behavior the README already promises. - Add `test-github-namespace` CI job + test workflow asserting github/* is verified without any allowlist entry. - Document the fix under an Unreleased CHANGELOG section. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
….4.3 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The README documents
github/*(alongsideactions/*) as a verified first-party publisher:But
check_verified_publisher()only hardcoded theactionsnamespace. For every other owner it scrapes the Marketplace page for the literal text "GitHub has manually verified the creator of the action as an official partner organization." GitHub does not apply that third-party "partner organization" badge to its own first-party org, sogithub/*actions could never be confirmed — and the checker reported spurious "Not from verified publisher" failures for first-party actions likegithub/codeql-action.This was found dogfooding the action against a repo whose only "failures" were
github/codeql-action/initand/analyze— both correctly SHA-pinned, both unmistakably first-party.Change
githubalongsideactionsin the always-verified branch ofcheck_verified_publisher(), matching the v1.4.2 precedent foractionsand the behavior the README already promises.test-github-namespaceCI job +test-workflows/github-namespace-test.ymlassertinggithub/*is verified without any allowlist entry.UnreleasedCHANGELOG section.Verification
Ran the patched script locally against a workflow containing pinned
github/codeql-action/{init,analyze}:🤖 Generated with Claude Code