sorted_copy is the builtin now - #2
Merged
Merged
Conversation
twill 1.9.0 orders a list of numbers, which is docs/needs.md entry 8, so the insertion sort in src/bars.tw becomes one line and weft ships no sort of its own. The old comment defended the quadratic version on the grounds that a histogram is drawn once per plot rather than per frame. That defence was fair and is no longer needed: it is not the simpler code any more, only the slower one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI installs v1.9.0 and spool.toml asks for ^1.9.0, because the sort this branch adopts is in that release and not in the one pinned before it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/needs.mdentry 8 closes: twill 1.9.0'ssortorders a list of numbers, so the insertion sort insrc/bars.twbecomes one line and weft ships no sort of its own.The old comment defended the quadratic version on the grounds that a histogram is drawn once per plot rather than per frame. That defence was fair and is no longer needed: it is not the simpler code any more, only the slower one.
CI and
spool.tomlmove to 1.9.0 in the second commit. Six suites pass.🤖 Generated with Claude Code