README and needs: weft runs, and it is the one repo that really needs 1.7 - #1
Merged
Merged
Conversation
martin-k-m
commented
Aug 21, 2026
martin-k-m
commented
Collaborator
- README and needs: weft runs, and it is the one repo that really needs 1.7
… 1.7 Every row of the status table said "written, unrun" and the tests row said "blocked on a test runner". twill test tests is 6 files, 6 passed, 0 failed. The table now carries an "Exercised by" column, and two rows were downgraded rather than upgraded: src/heatmap.tw is reached only through svg.tw with no test or example, and nothing anywhere constructs a Mark.Dot, so both read "runs, untested". The 1.7.0 floor is real here and nowhere else in the ecosystem. Under 1.6.7 the same suite is 3 passed, 3 failed: line 22: in import "theme.tw": line 33:5: expected identifier but found "0" src/theme.tw:33 and src/svg.tw:35 dispatch a palette index on integer literals as match patterns. Literal patterns arrived in 1.7.0; before that a pattern was a case name plus at most one binder. The README said twill 1.6 closed this, which is wrong. The src/term/ vendoring claim was stale. Nothing imports twill_modules/; src, tests and examples all import std/term/caps, ansi, width, box and frame, and the suite passes with no vendor directory at all. Worked examples corrected: std/term/caps not twill_modules/twill/src/term/caps.tw, live.push_now not live.push, ch.Line not ch.MARK_LINE. needs.md: six entries delivered, one mostly delivered, six still open and now measured rather than guessed. Section 1.2 was wrong about two of six bitwise operators: xor, shl and shr are bitwise, but and and or are the logical ones. Added a CHANGELOG from the 17 commits since v0.1.0, and gitignored examples/loss.svg, which running the example writes and CI would reject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.