The assertions are std/test - #6
Merged
Merged
Conversation
twill 1.11 ships the assertions every satellite harness copied by hand, and its own header names spool's is_none_i64 and equal_opt_i64 as the workaround its fail(name, why) replaces. Every suite imports std/test now, the three sites that used those helpers are a match whose wrong arm calls t.fail with what was there, and tests/harness.tw keeps one predicate and nothing that counts. The runner reads std/test's summary line, so twill test shows the counts beside each file: 207 assertions across six suites. docs/needs.md gains entry 15 to record it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
twill 1.11 ships
std/test, the assertions every satellite harness copied by hand, and its own header names spool'sis_none_i64andequal_opt_i64as the workaround itsfail(name, why)replaces: both recorded a failure ascheck(name, false)and threw away the reason.std/testast. The three sites that used those two helpers are amatchwhose wrong arm callst.failwith what was actually there.tests/harness.twkeeps one predicate,before, and nothing that counts. A helper that importsstd/testgets its own counter and its failures never reach the suite'sreport(measured in skein with a probe that came back green with a failure in it); the harness comment says so.reportreturns the status instead of callingexit, and prints its summary in the shapetwill testreads, so the runner shows the counts beside each file: 207 assertions across six suites, where it showed none.docs/needs.mdentry 15, since spool's file had no test-runner entry and skein's said the ask should be its own entry when someone wrote it. The pin was already 1.12.0.Verified locally on twill 1.12.0:
twill check .clean on every file,twill test tests6 of 6, no em dashes.🤖 Generated with Claude Code