model: read_unverified was still reading .err off a Res - #1
Merged
Merged
Conversation
martin-k-m
commented
Aug 21, 2026
martin-k-m
commented
Collaborator
- model: read_unverified was still reading .err off a Res
selvedge moved arc.read to Res[Archive, Str]. shuttle kept reading an err field off the result, so every archive load failed at runtime with "cannot access field err of a non-record". twill check was clean and all five suites were green the whole time, because nothing under tests/ ever opened an archive. tests/model_test.tw is that test: it writes an archive with selvedge, loads it back through shuttle, and covers the missing-file case. It fails against the old code. Six suites now, not five, and the README says six. examples/serve.tw runs end to end once loom and selvedge have produced the archive, and the chain is written down. Two more bugs twill check does not catch, both in the example: an array literal with a non-literal element is a list rather than a Tensor, and reshape wants an Arr[I64]. twill has a clock. mono_ns and clock_now_ms both work, and "there is no clock" appeared in this README, docs/needs.md, four source files and the changelog. For the batcher the real blocker was never the clock, it is that there is no concurrency to hold a batch against. Said so. round over tensors exists and is half-away-from-zero, which closes needs entry 14. Entry 16, an import form that expresses a package dependency, is the one entry twill 1.7 did not move: this suite needs selvedge checked out beside it, and the README now says so rather than pretending otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.