Skip to content

fix: use speechTimeout casing on ConversationRelay - #1195

Open
Hashim1999164 wants to merge 1 commit into
twilio:mainfrom
Hashim1999164:fix/conversationrelay-speechTimeout
Open

Hashim1999164 wants to merge 1 commit into
twilio:mainfrom
Hashim1999164:fix/conversationrelay-speechTimeout

Conversation

@Hashim1999164

Copy link
Copy Markdown

Fixes #1192

Summary

  • Rename ConversationRelayAttributes.speechtimeout to speechTimeout so the TypeScript type matches the TwiML spec and CHANGES.md
  • Add a unit test that asserts generated TwiML emits speechTimeout

Without this, following the types produces invalid TwiML that Twilio rejects. Passing the correct camelCase name already worked at runtime but failed type-checking.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Align ConversationRelayAttributes with the TwiML spec so TypeScript
callers emit speechTimeout instead of the rejected speechtimeout form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConversationRelayAttributes defines speechtimeout (lowercase) but TwiML spec requires speechTimeout (camelCase)

1 participant