Repository navigation
macos: adopt rivet RivetUpdate, retire the hand-rolled UpdateService - #14
Merged
Merged
Conversation
The 460-line hand-rolled update client (born here, hardened through the issue #13 stalled-OTA battle) is upstreamed into rivet 0.8.1 as the shared RivetUpdate Swift module. This file becomes a thin product adapter: it contributes the product facts (feed URL, signing key, key id, bundle name), the localized error surface, and test seams; signed- manifest verification, the bounded delegate-driven download, size/SHA enforcement, the ditto unpack + version confirmation, the atomic swap with rollback, the sheet-safe quit/relaunch handoff, and stale workdir sweeping all live in the library now. CI pins rivet to the v0.8.1 tag (docs/ci.md install contract) until the package catalog's main-tracking checksum catches up with the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The macOS update client born in this repo and hardened through the issue #13 stalled-OTA battle is now upstream: rivet 0.8.1 ships it as the shared
RivetUpdateSwift module (rivet#230), so the whole family stops re-implementing the same security-critical download/verify/swap flow — and re-hitting the same EOF/stuck-continuation, sheet-vetoes-terminate, and workdir-race bugs — per product.What
UpdateService.swiftshrinks from the 460-line hand-rolled implementation to a thin product adapter overRivetUpdateService: this file now only contributes the product facts (feed URL, signing key, key id,Taskly.appbundle name), the localized error surface, and test seams. Signed-wrapper verification (Ed25519 over exact payload bytes), the bounded delegate-driven download with progress/cancellation, size + SHA-256 enforcement (now also fail-fast on a disagreeing Content-Length), ditto unpack + bundle-version confirmation, the atomic swap with rollback, the sheet-safe quit/relaunch handoff, and the stale-workdir sweep all live in the library.macos-host/Package.swiftadds theRivetUpdateproduct dependency.#v0.8.1(the docs/ci.md install contract) in all ten install sites until the catalog's main-tracking checksum catches up.Verified locally:
raco rivet buildgreen against local rivet main, andstringson the stagedRivetHostbinary confirms the RivetUpdate symbols are linked in.Fixes the adoption half of #13's follow-up; real-machine OTA re-verification (check → download → swap → relaunch) rides the next release drill.