fix: msop and son number right-column pins counter-clockwise - #854
Open
birdup000 wants to merge 1 commit into
Open
fix: msop and son number right-column pins counter-clockwise#854birdup000 wants to merge 1 commit into
birdup000 wants to merge 1 commit into
Conversation
…it#677) msop/son numbered the right column top-to-bottom like the left, so on msop8/son8 pin 5 sat top-right and pin 8 bottom-right — mirrored against every other dual-row footprint (soic numbers correctly). Dual-row packages number counter-clockwise: down the left column, then UP the right, last pin across from pin 1. The pad loop now keeps left-column numbering and reverses the right column. Regression test asserts full CCW ordering on msop8, son8, and msop10. Fixes tscircuit#677
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677
What
msopandsonnumbered their right column top→bottom (same direction as the left), somsop8/son8put pin 5 top-right and pin 8 bottom-right — mirrored versussoic8, which numbers correctly. Dual-row packages are numbered counter-clockwise: pins 1..n/2 down the left column, then n/2+1..n up the right column, last pin across from pin 1.The pad loops now reverse only the right-column assignment (position code untouched). Repro after the fix:
Verification