fix: sot723 numbers pins per the Toshiba datasheet - #853
Open
birdup000 wants to merge 1 commit into
Open
Conversation
Pins 1 and 3 were swapped: pin 1 sat alone on the right and pin 3 top-left, so a real SOT-723 part would be mirrored/misnumbered on the PCB. Now pin 1 is top-left (-0.575, +0.4), pin 2 bottom-left, pin 3 alone on the right, matching KiCad and the Toshiba datasheet. Fixes tscircuit#686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #686
What
getCcwSot723Coordsmapped pin 1 to the lone right pad(0.575, 0)and pin 3 to top-left — the reverse of the Toshiba SOT-723 datasheet and KiCad'sSOT-723footprint. A real part would be misnumbered/mirrored on the assembled PCB.Swapped so:
(-0.575, +0.4)(top-left)(-0.575, -0.4)(bottom-left, unchanged)(0.575, 0)(alone on the right)Verification
tests/sot723-pin-order.test.tsasserts each pin's coordinates; SVG snapshots updated; full suite 565/565 pass, biome clean