fix: sot23 draws a body outline and pin-1 marker - #852
Open
birdup000 wants to merge 1 commit into
Open
Conversation
The 3-pin sot23 emitted zero pcb_silkscreen_path elements while every sibling SOT (sot23w, sot323, sot343...) draws a body outline. Adds the same two paths the siblings use: a rectangular body outline between the pad rows and a short pin-1 tick at the lone bottom pad, with >=0.15mm silk-to-pad clearance. Fixes tscircuit#732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732
What
sot23(3-pin) emitted zeropcb_silkscreen_pathelements — no body outline, no pin-1 marker — while every sibling SOT footprint (sot23w,sot323,sot343, …) draws two. Adds the same two paths in the sibling style:silkscreen_path_body: rectangular body outline spanning between the pad rowssilkscreen_path_pin1: short L tick marking the lone bottom pad (pin 1)Verification
fp.string("sot23")now emits 2pcb_silkscreen_pathelements (was 0); 3 pads unchangedtests/sot23-silkscreen.test.ts; SVG snapshots updated; full suite 565/565 pass, biome clean