fix: default LCC pitch to 1.27mm so pads do not overlap - #848
Open
birdup000 wants to merge 1 commit into
Open
Conversation
quad's 0.5mm default pitch left 0.6mm-wide pads overlapping by 0.1mm along each column — a short in the emitted PCB. LCC/PLCC lead pitch is 1.27mm, so lcc now defaults `p` to 1.27mm (explicit `p` still wins). Regression tests assert no adjacent-pad overlap for lcc20 and lcc44 and the exact 1.27mm default. Fixes tscircuit#794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #794
What
lccinherited quad's 0.5mm default pitch while defaulting pad width to 0.6mm, so adjacent pads in each column overlapped by 0.1mm — a short in the emitted PCB (reproduced: lcc44 right-column ys at 2.5/2.0/1.5 with 0.6mm pads).LCC/PLCC lead pitch is 1.27mm, so
lccnow defaultspto 1.27mm; an explicitpoverride still wins. After the fix the column reads 6.35/5.08/3.81 with 0.67mm clearance.Verification
lcc20andlcc44, and exact 1.27mm default pitch