Conversation
…3502) * fix(app): stop left-nav rail tooltips flickering on hover (CS-773) The far-left product rail (Compliance, Trust, Security, Settings, Admin) showed each icon's tooltip for ~0.1s on hover, then it vanished while the cursor was still over the icon. Root cause: ShellRailNavItem passed a label-derived `id` (`app-shell-rail-<label>`) to the design system's AppShellRailItem. AppShellRail re-renders the same rail items into the always-mounted mobile drawer, so each `id` ends up on two DOM elements. The design system forwards that `id` to the Base UI tooltip trigger, so the two copies register the same deterministic trigger id and collide in Base UI's floating tree. When the desktop tooltip opens, Base UI's closeOnActiveTriggerUnmount logic treats the active trigger as unmounted and closes the tooltip a microtask later — the flash. Fix: don't set an explicit `id` on the rail items. The `id` was unused anywhere in either repo, and without it the design system generates a unique id per instance, so the two copies no longer collide. Extracted ShellRailNavItem into its own file so it can be unit-tested; added a regression test asserting no hard-coded / duplicate rail-item ids. Verified by reproducing the flash with the real design system components in a headless browser (dup id => flash 5/5; no id => stable 5/5) and confirming the Base UI close path via runtime instrumentation. * style(app): prettier-format CS-773 rail nav test
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Contributor
|
🎉 This PR is included in version 3.108.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes flickering tooltips on the left product rail (Compliance, Trust, Security, etc.) by removing a hard-coded id so the design system can generate unique ids. Addresses Linear CS-773.
ShellRailNavItemand stopped passing an explicit id toAppShellRailItem, avoiding duplicate DOM ids across the desktop rail and the mirrored mobile drawer in@trycompai/design-system.Written for commit b4e0c57. Summary will update on new commits.