Conversation
* ## Mcp-typescript SDK Changes: * `CompAi.Policies.PoliciesController_createPolicyVersion_v1()`: * `request.body` **Changed** (Breaking⚠️ ) * `CompAi.Trust Portal.TrustPortalController_updateFaqs_v1()`: `request` **Added** (Breaking⚠️ ) * `CompAi.Trust Portal.TrustPortalController_updateOverview_v1()`: `request` **Added** (Breaking⚠️ ) * `CompAi.Trust Portal.TrustPortalController_createCustomLink_v1()`: `request` **Added** (Breaking⚠️ ) * `CompAi.Trust Portal.TrustPortalController_reorderCustomLinks_v1()`: `request` **Added** (Breaking⚠️ ) * `CompAi.ISMS.IsmsRegistersController_bulkCreateMeasurements_v1()`: **Added** * `CompAi.ISMS.IsmsRegistersController_createRow_v1()`: * `request.body` **Changed** * `CompAi.ISMS.IsmsRegistersController_updateRow_v1()`: * `request.body` **Changed** * empty commit to trigger [run-tests] workflow --------- Co-authored-by: speakeasybot <bot@speakeasyapi.dev> Co-authored-by: speakeasy-github[bot] <128539517+speakeasy-github[bot]@users.noreply.github.com> Co-authored-by: Tofik Hasanov <72318342+tofikwest@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 35 files
Confidence score: 4/5
- In
apps/mcp-server/src/models/ismsregisterscontrollercreaterowv1op.tsandapps/mcp-server/src/models/ismsregisterscontrollerupdaterowv1op.ts, cross-field/date-format validation is too permissive, so invalid audit date ranges reach the API and fail later, causing avoidable tool errors and poorer MCP user feedback — add date-order and ISO-date constraints in the OpenAPI source and regenerate these models before merging if you want cleaner validation behavior.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mcp-server/src/models/ismsregisterscontrollercreaterowv1op.ts">
<violation number="1" location="apps/mcp-server/src/models/ismsregisterscontrollercreaterowv1op.ts:266">
P3: The MCP create-row tool accepts an audit whose end date precedes its start date, then surfaces an API rejection instead of an input-validation error. Add cross-field date-order validation in the generated schema source and regenerate.
(Based on your team's feedback about audit date-order validation.) [FEEDBACK_USED]</violation>
</file>
<file name="apps/mcp-server/src/models/ismsregisterscontrollerupdaterowv1op.ts">
<violation number="1" location="apps/mcp-server/src/models/ismsregisterscontrollerupdaterowv1op.ts:267">
P3: Invalid audit dates pass MCP validation and fail only after the API request. Generate ISO-date constraints for `plannedStartDate`/`plannedEndDate` from the OpenAPI source (rather than editing this generated model); retain API validation for effective partial-update ranges.
(Based on your team's feedback about audit date-order validation.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| "First day of the covered period (YYYY-MM-DD), aligned to the metric cadence", | ||
| ), | ||
| plan: z.string().optional(), | ||
| plannedEndDate: z.string().nullable().optional(), |
Contributor
There was a problem hiding this comment.
P3: The MCP create-row tool accepts an audit whose end date precedes its start date, then surfaces an API rejection instead of an input-validation error. Add cross-field date-order validation in the generated schema source and regenerate.
(Based on your team's feedback about audit date-order validation.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/models/ismsregisterscontrollercreaterowv1op.ts, line 266:
<comment>The MCP create-row tool accepts an audit whose end date precedes its start date, then surfaces an API rejection instead of an input-validation error. Add cross-field date-order validation in the generated schema source and regenerate.
(Based on your team's feedback about audit date-order validation.) </comment>
<file context>
@@ -109,50 +169,126 @@ export type IsmsRegistersControllerCreateRowV1RequestBody = {
+ "First day of the covered period (YYYY-MM-DD), aligned to the metric cadence",
+ ),
plan: z.string().optional(),
+ plannedEndDate: z.string().nullable().optional(),
+ plannedStartDate: z.string().nullable().optional(),
position: z.int().optional(),
</file context>
| ), | ||
| plan: z.string().optional(), | ||
| plannedEndDate: z.string().nullable().optional(), | ||
| plannedStartDate: z.string().nullable().optional(), |
Contributor
There was a problem hiding this comment.
P3: Invalid audit dates pass MCP validation and fail only after the API request. Generate ISO-date constraints for plannedStartDate/plannedEndDate from the OpenAPI source (rather than editing this generated model); retain API validation for effective partial-update ranges.
(Based on your team's feedback about audit date-order validation.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mcp-server/src/models/ismsregisterscontrollerupdaterowv1op.ts, line 267:
<comment>Invalid audit dates pass MCP validation and fail only after the API request. Generate ISO-date constraints for `plannedStartDate`/`plannedEndDate` from the OpenAPI source (rather than editing this generated model); retain API validation for effective partial-update ranges.
(Based on your team's feedback about audit date-order validation.) </comment>
<file context>
@@ -109,50 +169,126 @@ export type IsmsRegistersControllerUpdateRowV1RequestBody = {
+ ),
plan: z.string().optional(),
+ plannedEndDate: z.string().nullable().optional(),
+ plannedStartDate: z.string().nullable().optional(),
position: z.int().optional(),
remediationAction: z.string().nullable().optional(),
</file context>
Contributor
|
🎉 This PR is included in version 3.107.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Releases
@trycompai/mcp-serverv0.2.4 to production with an updated SDK, a new ISMS bulk measurements API/tool, and stricter request payloads for Trust Portal endpoints.New Features
bulk-create-measurements.update-overview,update-faqs,create-custom-link, andreorder-custom-links.Migration
CreatePolicyVersionDto(use optionalsourceVersionIdandchangelog; removeversion/scriptKey).updateFaqsnow requires{ faqs: [{ question, answer }] }.updateOverviewnow requires{ organizationId, overviewTitle?, overviewContent?, showOverview? }.createCustomLinknow requires{ organizationId, title, url, description? }.reorderCustomLinksnow requires{ organizationId, linkIds }.planned,in_progress, etc.); update clients accordingly.Written for commit ff39e19. Summary will update on new commits.