You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fork of Trustabl’s rule repository, extended with LC-103, a LangChain v1 detection rule for dangerous create_agent configurations that lack visible human-review prerequisites.
Thanks @Mantitah. The rule is schema clean: every required field is set, there are no extra keys, confidence is in range, language is explicit, and langchain_agent is a valid applies_to for agent scope. All four predicates already exist on main at schema 14, so no version bump is needed, and I like that the explanation is honest that middleware presence does not prove HumanInTheLoopMiddleware is actually wired.
My concern is overlap. LC-101 in langchain/agent_safety.yaml already fires at langchain_agent on exactly these three hosted classes with no further condition, so every LC-103 hit is also an LC-101 hit and a create_agent wiring PythonREPLTool would emit two high findings for one call site. On top of that, a checkpointer passed in when a parent graph is compiled is invisible to us, so the missing-checkpointer arm will fire on correct code. Please drop LC-103 to medium (LC-101 stays the capability call, LC-103 the gate refinement), or narrow the match so it is not a strict subset of LC-101.
Two notes that are not on you. LC-103 is also claimed by #103 and #108 for an unrelated Requests built-in rule, so whoever lands second renumbers. And a shipped rule needs a rationale doc in trustabl-rulebook; we can write that or pair on it.
The engine half at trustabl/trustabl#186 mirrors this byte for byte, which is right. Happy to take this once severity is settled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork of Trustabl’s rule repository, extended with LC-103, a LangChain v1 detection rule for dangerous create_agent configurations that lack visible human-review prerequisites.