Skip to content

fix(install): do not resolve jq/awk through the downloaded release #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fxmedus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install): do not resolve jq/awk through the downloaded release #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions scan/trustabl-scan.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ curl -fSL -H "Accept: application/octet-stream" "${AUTH[@]}" \
# ---- verify checksum (sha256 against the release checksums.txt) ----
if curl -fsSL "${AUTH[@]}" -o "$DEST/checksums.txt" \
"https://github.com/trustabl/trustabl/releases/download/${VER}/checksums.txt" 2>/dev/null; then
EXPECTED=$(grep " ${ASSET}\$" "$DEST/checksums.txt" | awk '{print $1}' | head -1)
# Match the asset name literally. $ASSET contains dots, which grep treats as
# wildcards, so a checksums.txt entry differing from the wanted asset only at
# those positions would satisfy the match. Compare field 2 for equality
# instead, allowing sha256sum's binary-mode "*" prefix.
EXPECTED=$(awk -v a="$ASSET" '$2 == a || $2 == "*" a { print $1 }' "$DEST/checksums.txt" | head -1)
if [ -n "$EXPECTED" ]; then
ACTUAL=$(sha256sum "$DEST/$ASSET" | awk '{print $1}')
if [ "$EXPECTED" != "$ACTUAL" ]; then
Expand All @@ -105,7 +109,14 @@ else
fi

tar -xzf "$DEST/$ASSET" -C "$DEST"
export PATH="$DEST:$PATH"
# Bind the downloaded binary by path rather than prepending $DEST to PATH.
# $DEST holds a just-extracted release tarball; putting it first on PATH means
# every later `jq` and `awk` in this script resolves out of that tarball, so a
# compromised release asset could supply its own jq and control every score the
# wrapper computes. jq is already required before the download exists (the
# "latest" version lookup above uses it), so it is a system prerequisite and
# nothing here depends on the tarball providing it.
TRUSTABL_BIN="$DEST/trustabl"

# ---- scan ----
set +e
Expand Down Expand Up @@ -134,11 +145,11 @@ BASE_ARGS=(scan "$TARGET")
[ -n "$RULES_REF" ] && BASE_ARGS+=(--rules-ref "$RULES_REF")

# Run 1: SARIF (file emit).
trustabl "${BASE_ARGS[@]}" --format sarif > "$SARIF_FILE"
"$TRUSTABL_BIN" "${BASE_ARGS[@]}" --format sarif > "$SARIF_FILE"
NATIVE_CODE=$?

# Run 2: JSON (drives thresholds, log summary, dotenv).
trustabl "${BASE_ARGS[@]}" --format json > "$JSON_FILE" || true
"$TRUSTABL_BIN" "${BASE_ARGS[@]}" --format json > "$JSON_FILE" || true
SCAN_END=$(date -u +%Y-%m-%dT%H:%M:%S)

# trustabl's overall_score is a float in [0.0, 1.0]; scale to [0,100] ints.
Expand Down