Repository navigation
nextcloud-fpm: write Talk STUN/TURN servers with array type - #209
Merged
Merged
Conversation
Talk 25 declares spreed stun_servers and turn_servers as arrays in its
config lexicon. set_app_value writes them as mixed, which Nextcloud
rejects ("Config value were not updated"), leaving both keys unset after
every start, so calls fail without a TURN server.
Add set_app_array_value, which writes with --type=array and pipes the
confirmation occ asks for whenever a type is passed.
Fixes truenas#208
stavros-k
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208
Problem
Talk 25 (spreed, stable35) declares
stun_serversandturn_serversasValueType::ARRAYin its config lexicon.set_app_valuewrites without--type(asmixed), which Nextcloud rejects for these keys:config:app:setprintsConfig value were not updated, and because the key was deleted right before, both end up unset after every start. Clients then get no TURN server, and calls fail withICE failedin the talk container.Change
helpers.sh: addset_app_array_value, which deletes the key and writes it with--type=array.occasks for confirmation whenever--typeis given (even for a key that was just deleted) and aborts without an answer, soyesis piped in.occ-talk.sh: use it forstun_serversandturn_servers.signaling_servers(not in the lexicon) and the recording keys are unchanged.set_app_valuestays as it is for keys without a lexicon type, as its comment explains.Testing
sh -non both files.occ_talk_installinside a runningixsystems/nextcloud-fpm:35.0.1container (Talk 25.0.2):occ config:app:getthen returns the configured STUN/TURN servers, andsignaling_serversis unchanged.Confirm this action by typing 'yes': Aborted.) and leaves the key unset.