Repository navigation
backfill sandbox environment where it is undefined - #1400
Merged
Merged
Conversation
heerambavi1998
requested review from
chiragjn,
debajyoti-truefoundry and
thesujai
as code owners
November 16, 2026 12:36
🦋 Changeset detectedLatest commit: eff54c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chiragjn
reviewed
Nov 16, 2026
chiragjn
reviewed
Nov 16, 2026
chiragjn
approved these changes
Nov 16, 2026
chiragjn
left a comment
Member
There was a problem hiding this comment.
Approving with some comments
heerambavi1998
force-pushed
the
ha/sandbox-422
branch
from
November 16, 2026 14:35
b5b7fba to
9014541
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eff54c8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Sets it to the default env if any, otherwise to the trueforge managed sandbox env.
fixes AGE-2834
Note
Medium Risk
Irreversible DB migration rewrites agent/session JSON for all affected tenants; incorrect pinning could misroute sandboxes, though scope is limited to rows with sandbox enabled and no environment name.
Overview
Requires
config.sandbox.environment_namewhen sandbox is on and the provider supports environments (e.g. Daytona)—OpenAPI, Zod agent spec, and regenerated TS/Python SDK descriptions no longer treat omit-as-default as valid. Docs and examples now show an explicit environment name and document the requirement.Adds irreversible Postgres and SQLite migrations that backfill missing
environment_nameon saved agent manifests and inline sessionagent_specwheresandbox.enabledis true, using each tenant’s default active sandbox environment or falling back totrueforge-sandbox-env. This repairs legacy rows that would 422 on session create under the stricter validation (fixes AGE-2834).Reviewed by Cursor Bugbot for commit eff54c8. Bugbot is set up for automated code reviews on this repo. Configure here.