Skip to content

backfill sandbox environment where it is undefined - #1400

Merged
heerambavi1998 merged 4 commits into
mainfrom
ha/sandbox-422
Nov 16, 2026
Merged

heerambavi1998 merged 4 commits into
mainfrom
ha/sandbox-422

Conversation

@heerambavi1998

@heerambavi1998 heerambavi1998 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Sets it to the default env if any, otherwise to the trueforge managed sandbox env.
fixes AGE-2834


Note

Medium Risk
Irreversible DB migration rewrites agent/session JSON for all affected tenants; incorrect pinning could misroute sandboxes, though scope is limited to rows with sandbox enabled and no environment name.

Overview
Requires config.sandbox.environment_name when sandbox is on and the provider supports environments (e.g. Daytona)—OpenAPI, Zod agent spec, and regenerated TS/Python SDK descriptions no longer treat omit-as-default as valid. Docs and examples now show an explicit environment name and document the requirement.

Adds irreversible Postgres and SQLite migrations that backfill missing environment_name on saved agent manifests and inline session agent_spec where sandbox.enabled is true, using each tenant’s default active sandbox environment or falling back to trueforge-sandbox-env. This repairs legacy rows that would 422 on session create under the stricter validation (fixes AGE-2834).

Reviewed by Cursor Bugbot for commit eff54c8. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eff54c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@truefoundry/trueforge-sdk Patch
@truefoundry/trueforge Patch
@truefoundry/trueforge-core Patch
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@veria-ai

veria-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Fixed/addressed: 1 · PR risk: 0/10

Reviews

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@chiragjn chiragjn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eff54c8. Configure here.

@heerambavi1998
heerambavi1998 merged commit e4fd3d4 into main Nov 16, 2026
15 checks passed
@heerambavi1998
heerambavi1998 deleted the ha/sandbox-422 branch November 16, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants