Skip to content

fix : Make Approve once clickable without opening the dropdown - #1399

Open
harshil-2096 wants to merge 2 commits into
mainfrom
bugfix/hv/make-approve-once-clickable-without-opening
Open

harshil-2096 wants to merge 2 commits into
mainfrom
bugfix/hv/make-approve-once-clickable-without-opening

Conversation

@harshil-2096

@harshil-2096 harshil-2096 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

… additional options

Summary

image

Closes AGE-2848

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, python/trueforge_sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
UI interaction change in ToolApprovalBar only; deny/reason flows unchanged and covered by updated tests.

Overview
Splits the tool approval control so the primary label (e.g. Approve once) is its own button that immediately calls onSelect with the default approval option, instead of only opening a menu.

The chevron is a separate control (aria-label: More approval options) that still opens the dropdown for alternate approve choices and deny flows. Unit and container tests were updated for the new click targets; a patch changeset records the UX fix (AGE-2848).

Reviewed by Cursor Bugbot for commit 8270267. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8270267

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@veria-ai

veria-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR overview

No security issues were found in this pull request.

Reviews

@harshil-2096 harshil-2096 changed the title fix : Approve once now triggers approval on click, with a chevron for… fix : Make Approve once clickable without opening the dropdown Nov 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 43e075e. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant