Repository navigation
trueforge mcp fixes - #1398
trueforge mcp fixes#1398
Conversation
🦋 Changeset detectedLatest commit: 12c59c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 66cb13f. Configure here.
66cb13f to
03a04af
Compare
chiragjn
left a comment
There was a problem hiding this comment.
Approving with minor comments

fixes AGE-2829, AGE-2806, AGE-2790
Note
Medium Risk
Changes approval gating and orchestration for system MCP tools plus rewrites the TrueForge MCP internal API client, affecting security-sensitive tool execution paths.
Overview
TrueForge MCP write/destructive tools are approval-gated again, and session/timed approval policies now apply to the built-in TrueForge MCP—not only user MCP servers.
IToolSetaddssupportsApprovals; orchestration usesgetToolSets()(system + user) and only records policies on sets where that flag is true. TrueForge tool selectors useDEFAULT_REQUIRE_APPROVAL_FOR_TOOLS, and policies resume from the prior turn snapshot.Product copy and tool behavior were updated so agents can discover attaching MCP servers/skills to the chat;
update_current_sessioninstructs the model to prompt for the next user message after attach. Session-only tools get clearer session errors.Internal MCP HTTP drops the Fern SDK:
createWireApiClientissues authenticated requests via process mTLSfetchand the caller’s bearer token, with explicit URL building and timeouts.Reviewed by Cursor Bugbot for commit 12c59c9. Bugbot is set up for automated code reviews on this repo. Configure here.