Skip to content

trueforge mcp fixes - #1398

Merged
heerambavi1998 merged 9 commits into
mainfrom
ha/sandbox-docs
Nov 16, 2026
Merged

heerambavi1998 merged 9 commits into
mainfrom
ha/sandbox-docs

Conversation

@heerambavi1998

@heerambavi1998 heerambavi1998 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
  • allow approvals for system tool sets, and specifically for trueforge mcp
  • fix descriptions to fix failures to automatically discover MCP
  • remove dependency on fern client
    fixes AGE-2829, AGE-2806, AGE-2790

Note

Medium Risk
Changes approval gating and orchestration for system MCP tools plus rewrites the TrueForge MCP internal API client, affecting security-sensitive tool execution paths.

Overview
TrueForge MCP write/destructive tools are approval-gated again, and session/timed approval policies now apply to the built-in TrueForge MCP—not only user MCP servers. IToolSet adds supportsApprovals; orchestration uses getToolSets() (system + user) and only records policies on sets where that flag is true. TrueForge tool selectors use DEFAULT_REQUIRE_APPROVAL_FOR_TOOLS, and policies resume from the prior turn snapshot.

Product copy and tool behavior were updated so agents can discover attaching MCP servers/skills to the chat; update_current_session instructs the model to prompt for the next user message after attach. Session-only tools get clearer session errors.

Internal MCP HTTP drops the Fern SDK: createWireApiClient issues authenticated requests via process mTLS fetch and the caller’s bearer token, with explicit URL building and timeouts.

Reviewed by Cursor Bugbot for commit 12c59c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 12c59c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge Patch
@truefoundry/trueforge-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@veria-ai

veria-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR overview

No security issues were found in this pull request.

Reviews

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 66cb13f. Configure here.

@chiragjn chiragjn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments

@heerambavi1998
heerambavi1998 enabled auto-merge (squash) November 16, 2026 14:12
@heerambavi1998
heerambavi1998 merged commit 5f25401 into main Nov 16, 2026
12 of 13 checks passed
@heerambavi1998
heerambavi1998 deleted the ha/sandbox-docs branch November 16, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants