Skip to content

Modernize project to Go 1.25 and address security vulnerabilities #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snskArora merged 4 commits into from
Jun 27, 2026
Merged

Modernize project to Go 1.25 and address security vulnerabilities #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f5722f
Modernizing to go 1.25
snskArora Jun 27, 2026
3269af9
Merge branch 'trstringer:main' into security/vulnerability_fix
snskArora Jun 27, 2026
6e1700a
Upgrade Go image to 1.25 and adjust Dockerfile
snskArora Jun 27, 2026
d339c9e
Update golangci-lint version in Makefile
snskArora Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
FROM golang:1.24@sha256:d2d2bc1c84f7e60d7d2438a3836ae7d0c847f4888464e7ec9ba3a1339a1ee804 AS builder
# not pinning the exact image digest to support multiple architecture builds without multiple Dockerfiles

FROM golang:1.25 AS builder
COPY . /var/app
WORKDIR /var/app
RUN go mod tidy
RUN CGO_ENABLED=0 go build -o app .

FROM alpine:3.23@sha256:fd791d74b68913cbb027c6546007b3f0d3bc45125f797758156952bc2d6daf40
FROM alpine:3.23
LABEL org.opencontainers.image.source=https://github.com/trstringer/manual-approval
RUN apk update && apk add ca-certificates
COPY --from=builder /var/app/app /var/app/app
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ test:

.PHONY: lint
lint:
docker run --rm -v $$(pwd):/app -w /app golangci/golangci-lint:v2.1.6 golangci-lint run -v
docker run --rm -v $$(pwd):/app -w /app golangci/golangci-lint:v2.10.1 golangci-lint run -v
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/trstringer/manual-approval

go 1.24.0
go 1.25.0

require (
github.com/google/go-github/v43 v43.0.0
Expand All @@ -9,5 +9,5 @@ require (

require (
github.com/google/go-querystring v1.1.0 // indirect
golang.org/x/crypto v0.45.0 // indirect
golang.org/x/crypto v0.53.0 // indirect
)
Loading