feature: 支持用户传入http client 到 OpenAIModel 中来控制连接的生命周期#83
Merged
Conversation
raychen911
commented
Jun 17, 2026
raychen911
commented
Contributor
- 修改trace的调用方式避免上传trace不全
raychen911
force-pushed
the
feature/http_client_to_model
branch
2 times, most recently
from
ed3f5db to
9d34038
Compare
- 修改trace的调用方式避免上传trace不全
raychen911
force-pushed
the
feature/http_client_to_model
branch
from
9d34038 to
c46b645
Compare
helloopenworld
approved these changes
Jun 18, 2026
| # An externally-injected http client is owned by the caller and | ||
| # reused across requests; only close clients we created ourselves. | ||
| if self._http_client is None: | ||
| await client.close() |
Contributor
There was a problem hiding this comment.
这个client的关闭是不是可以去掉？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.