Repository navigation
fix: clean token IDs and decode wrapped TRON addresses - #158
Merged
CodeNinjaEvan merged 1 commit intoNov 12, 2026
Merged
CodeNinjaEvan merged 1 commit into
CodeNinjaEvan merged 1 commit into
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
CodeNinjaEvan
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy
transferToken(amount, uint24(x))could consume dirty upper bits instead of the narrowed token ID. Convert the second argument to its declaredtrcTokentype before the existing range checks.User-defined address types now reuse the underlying TRON address decoder and validator in both backends, including calldata array reads. This preserves historical 21-byte input compatibility and cleans decoded scalar addresses to 160 bits.
Regression coverage includes constant and runtime token IDs with optimization on/off; standard, prefixed and oversized address inputs; payable address wrappers; memory decoding and calldata/memory arrays; and invalid integer, boolean and fixed-bytes inputs. The new regressions were confirmed to fail before the fix.
Validation:
solcandsoltest.StandardCompiler: 66 tests and 1,995 assertions passed.git diff --checkpassed.Related: JT-892, JT-893, JT-894.