fix(configure): honor deploy.yml db credentials and pass --instance-dir#46
Merged
Conversation
- Create the Postgres role using the `db_user`/`db_password` forwarded in `deploy.yml` (random fallback when absent), so `odoo.conf` and the actual role no longer disagree. - Pass `--instance-dir` to odoo-config so it derives `logfile`, `data_dir` and `sentry_odoo_dir` from the instance home. Forge-ID: 68053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two configure fixes so the generated Odoo config and the host state match the
values supplied in
deploy.yml.Contents
db_useranddb_passwordfromdeploy.ymlinstead of always using the instance name with a randompassword. A missing or blank password falls back to a generated one (printed
once), so a misconfigured value can't silently set an unusable password.
odoo-configis now called with--instance-dir, so it derives the logfile, data dir and sentry dir from the instance's home directory.
Forge-ID: 68053