Fix open boundaries with periodic boundary zone#1237
Open
efaulhaber wants to merge 6 commits into
Open
Conversation
efaulhaber
commented
Jul 3, 2026
efaulhaber
left a comment
Member
Author
There was a problem hiding this comment.
Codex Review
The PR updates open-boundary particle classification and transfer to use periodic coordinates, with a regression test covering conversion near a periodic boundary. I did not identify correctness or regression issues in the changed production behavior.
This is an AI-generated code review. Please verify the findings and summary before acting on them.
Review generated by codex-pr-review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
=======================================
Coverage 90.11% 90.11%
=======================================
Files 137 137
Lines 10761 10765 +4
=======================================
+ Hits 9697 9701 +4
Misses 1064 1064
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When simulating periodic boundaries top/bottom and open boundaries left/right, the boundary zones are periodic in tangential direction. This doesn't work on main, as fluid particles that passed through the periodic boundary (in the screenshot below particles from the bottom that appear at the top) don't get converted when entering the boundary zone.
Note the orphaned fluid particles at the top in this screenshot.
