Repository navigation
Conversation
Complete a bare slice before it can reduce to a collection range element. Keep slices with a following subpattern on their existing precedence path. Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
items is [..] && readycurrently parses the list as a collection expression inside a constant pattern, so&& readybecomes part of the pattern. The same problem affects||.Give a completed bare slice higher precedence than a range expression, while keeping slices with a following subpattern on their existing path. The regression corpus checks that the logical operator remains outside
isand that[..]is alist_patterncontaining aslice_pattern.Verified with upstream tree-sitter CLI 0.26.5: all 180 corpus tests and 892 highlight assertions pass; the new test fails against the original parser.
npm run lintalso passes. Existing collection/range/list controls retain identical CSTs and expression, lvalue, non-lvalue, and pattern query captures. The generated node schema is unchanged.