Repository navigation
fix: allow async as a contextual identifier - #442
Closed
DavidBakerEffendi wants to merge 1 commit into
Closed
DavidBakerEffendi wants to merge 1 commit into
DavidBakerEffendi wants to merge 1 commit into
Conversation
Treat async as an identifier outside modifier positions while preserving async methods, local functions, lambdas, and anonymous methods through explicit precedence. Add a focused corpus regression covering an async parameter used as an invocation argument alongside genuine async constructs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat async as a contextual identifier in ordinary expression positions while preserving its structured modifier role for methods, local functions, lambdas, and anonymous methods.
For example, this valid C# currently produces a parse error because the argument is tokenized as a modifier instead of an identifier:
The grammar now permits that identifier use while explicitly preferring the modifier interpretation where required. The corpus regression also keeps genuine async methods and lambdas structured.
Fixes part of #276