🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in CLI executor - #401
🛡️ Sentinel: [HIGH] Fix SSRF vulnerability in CLI executor#401rschumann wants to merge 1 commit into
Conversation
🚨 **Severity:** HIGH
💡 **Vulnerability:** G704 (SSRF) was flagged in `/app/internal/runtime/executor/cli_executor.go` due to unsafe URL reconstruction. Modifying the `Path` of a copied `url.URL` struct without clearing the `Opaque` field allows an attacker to bypass path constraints by providing an opaque URL.
🎯 **Impact:** An attacker could craft an opaque URL that bypasses the `/run` path suffix enforcement, allowing SSRF to arbitrary paths on the destination host.
🔧 **Fix:** Replaced the unsafe modification of the copied `url.URL` struct with explicit reconstruction using a new `url.URL{...}` literal, ensuring only the `Scheme`, `Host`, `User`, `Path`, and `RawQuery` are preserved. Included security comment.
✅ **Verification:** Ran `gosec` scan and verified the code follows secure URL reconstruction patterns. Tested using `go test ./... -short` to verify functionality.
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: G704 (SSRF) was flagged in
/app/internal/runtime/executor/cli_executor.godue to unsafe URL reconstruction. Modifying thePathof a copiedurl.URLstruct without clearing theOpaquefield allows an attacker to bypass path constraints by providing an opaque URL.🎯 Impact: An attacker could craft an opaque URL that bypasses the
/runpath suffix enforcement, allowing SSRF to arbitrary paths on the destination host.🔧 Fix: Replaced the unsafe modification of the copied
url.URLstruct with explicit reconstruction using a newurl.URL{...}literal, ensuring only theScheme,Host,User,Path, andRawQueryare preserved. Included security comment.✅ Verification: Ran
gosecscan and verified the code follows secure URL reconstruction patterns. Tested usinggo test ./... -shortto verify functionality.PR created automatically by Jules for task 2883672848600129432 started by @rschumann