⚡ Bolt: [performance improvement] Pool bytes.Buffer in ResponseWriterWrapper - #384
⚡ Bolt: [performance improvement] Pool bytes.Buffer in ResponseWriterWrapper#384rschumann wants to merge 1 commit into
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
sync.Poolto recyclebytes.Bufferinstances in theResponseWriterWrappermiddleware instead of allocating a new buffer per request. Also ensures thePutaction is placed in adeferblock inFinalizeso early-returned (unlogged) requests don't leak the buffer.🎯 Why:
ResponseWriterWrapperintercepts and records all API request responses. By default, it allocates a newbytes.Bufferfor every non-streaming response. This results in heavy allocation pressure on the garbage collector in high-throughput API gateway scenarios. Reusing buffers reduces allocations per operation significantly. To prevent memory leaks, buffers are only returned to the pool if their capacity is <= 128KB.📊 Impact: Reduces GC pressure and memory allocations per API request.
🔬 Measurement: Benchmark tests show allocations dropping from 14 to 12 per operation, and memory per operation decreasing from ~1200 B/op to ~1088 B/op, improving speed slightly (~1987 ns/op to ~1904 ns/op).
PR created automatically by Jules for task 3612586863543969662 started by @rschumann