Skip to content

Guard against over-length origins#260

Merged
AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:origins_less_than_255
Jun 29, 2026
Merged

Guard against over-length origins#260
AlCutter merged 1 commit into
transparency-dev:mainfrom
AlCutter:origins_less_than_255

Conversation

@AlCutter

Copy link
Copy Markdown
Collaborator

This PR enforces the requirement that log (and mirror) origins are no longer than 255 bytes.

This is implicitly required by tlog-cosignature, which uses uint8 when encoding origin lengths in the MLDSA cosigned message.

@AlCutter AlCutter requested a review from mhutchinson June 26, 2026 12:09
@AlCutter AlCutter requested a review from a team as a code owner June 26, 2026 12:09
@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.79%. Comparing base (fa00c16) to head (7ff1861).
⚠️ Report is 172 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   82.57%   76.79%   -5.79%     
==========================================
  Files           5        8       +3     
  Lines         241      698     +457     
==========================================
+ Hits          199      536     +337     
- Misses         30       89      +59     
- Partials       12       73      +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread note/note_cosigv1.go Outdated
@AlCutter AlCutter force-pushed the origins_less_than_255 branch from 588deb3 to 7ff1861 Compare June 29, 2026 09:45
@AlCutter AlCutter merged commit fa283eb into transparency-dev:main Jun 29, 2026
14 checks passed
@AlCutter AlCutter deleted the origins_less_than_255 branch June 29, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants