docs(phase5): mark tasks 1, 2, 4 complete; document task 3 deferral (libcvc geometry consumer audit)#33
Merged
Conversation
…libcvc geometry consumer audit) Audit on master 2dc94f6 confirms F2Dock has zero remaining Blurmaps / GOA / PRGN direct consumers in either src/ or inc/. The only references to those legacy names live in F3Dock/src/f2dock/CMakeLists.txt -- the upstream migration source tree, not this destination tree. Phase 5 task 4 (libcvc geometry consumer) is therefore trivially complete: there is nothing to port. The libcvc-consumption pathway is now the established convention going forward (find_package(cvc CONFIG); file upstream issues for missing capability rather than vendoring a parallel copy). Also marks tasks 1 (PR #31) and 2 (PR #32) complete with cross-links to the merged PRs, and documents task 3 (NFFT in the electrostatics gridding path) as deferred until libnfft3 is available in at least one CI runner image -- without that prerequisite, the NFFT3 fastsum fast path in FastGaussianSum::evaluate cannot be exercised, and the guarded call site in the gridding loop would be unreachable dead code on every current CI platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only update that closes out Phase 5 task 4 (libcvc geometry consumer audit) and brings the migration matrix in line with the merged state of master.
Audit findings
A
rg -i 'blurmap|\bGOA\b|PRGN'sweep overF2Dock/src/andF2Dock/inc/on master2dc94f6returns zero matches. The only references to those legacy names in the workspace live inF3Dock/src/f2dock/CMakeLists.txt, i.e. the upstream migration source tree rather than this destination tree.Phase 5 task 4 is therefore trivially complete: F2Dock has no Blurmaps / GOA / PRGN consumers left to port. The libcvc-consumption pathway is established as the convention going forward -- when future F2Dock work needs surface generation, signed-distance fields, or related geometry primitives, the call goes through
find_package(cvc CONFIG)and any missing capability is filed upstream against libcvc rather than vendored locally.This matches the guiding principle the project owner laid down for this phase:
Phase 5 status after this PR
f3dock-nfftFastGaussianSum wrapper + direct evaluatorTask 3 deferral rationale
The NFFT3 fastsum fast path in
FastGaussianSum::evaluateis currently a no-op fallback. Wiring a guarded call site into the gridding loop at this point would create unreachable dead code on every current CI platform (FastGaussianSum::is_accelerated()always returnsfalse). Task 3 unblocks the moment libnfft3 lands in at least one CI runner image; at that point we (a) finish the NFFT3 fastsum hookup inFastGaussianSum::evaluate, (b) route the gridding loop through it underpr.nfftAccelerate && FastGaussianSum::is_accelerated(), and (c) add an1A2K_nfft_smokeintegration baseline with loosened numeric tolerance.Verification
clang-format-18 --Werror-- not applicable.