Two follow-ups from the review of #591 (tps agent create reports success only after the stored key reads back equal):
- When the read-back itself fails (a non-404 error),
create cannot tell whether an Agent row exists, and it prints the no-row remedy. If a row does exist, flair agent add then refuses and the operator has no next step. The fix: when row existence is unknown, the remedy names both branches ("if flair agent show <id> (or the equivalent read that exists on flair main) finds the agent, run flair agent remove <id> first, with the warning about what remove deletes; otherwise ..."). Test: a read-back failure prints both branches.
- Nothing tests that the operator credential used for the read-back never appears in stdout or stderr on any path. The fix: a test that runs each refusal path and the success path with a recognisable credential value and asserts it appears in neither stream.
Refs #512.
Two follow-ups from the review of #591 (
tps agent createreports success only after the stored key reads back equal):createcannot tell whether an Agent row exists, and it prints the no-row remedy. If a row does exist,flair agent addthen refuses and the operator has no next step. The fix: when row existence is unknown, the remedy names both branches ("ifflair agent show <id>(or the equivalent read that exists on flair main) finds the agent, runflair agent remove <id>first, with the warning about what remove deletes; otherwise ..."). Test: a read-back failure prints both branches.Refs #512.