Merge upstream/main (ed1f927, 3 commits) - #15
Merged
Merged
Conversation
) * fix(bash): propagate native exit codes through Windows PowerShell 5.1 wrappers Windows PowerShell 5.1 exits 0 after '& ([ScriptBlock]::Create($src))' (FullLanguage stdin transport) and after 'Invoke-Expression $src' (ConstrainedLanguage transport), regardless of $LASTEXITCODE set by native commands inside the user command. Every failing native command was therefore reported as success by the bash tool on hosts without pwsh 7, in both the foreground result and the background task status. Reproduced with the exact stdin wrapper: 'node -e "...;process.exit(7)"' emits its stderr while powershell.exe exits 0. Append 'exit $LASTEXITCODE' to both wrappers, the same idiom the first-party versioned-prefix launchers already use. Verified on Windows 11 (PS 5.1): pure-PowerShell payloads exit 0, native exit 7 (with or without a trailing PowerShell tail) exits 7, terminating PowerShell errors still exit 1, and packages/local-runtime/test/unit/child-bash-lifecycle.test.ts 'failure' mode passes (failed before the fix: task status was 'succeeded'). * test(bash): cover Windows PowerShell exit codes Force PowerShell 5.1 for native failures, successful commands, terminating errors and explicit exits with and without the parent-death guard. Assisted-by: codex-cli reason:github-issue-297-regression-coverage --------- Co-authored-by: Ralle1976 <ralf.arnold@it-bfw.de> Co-authored-by: qinjiu <qinjiu@minimaxi.com>
* fix(windows): clarify source checkout requirements Skip only WSL conversion fixtures on native Windows and add an explicit local-NTFS preflight to the source-build instructions. Cover localized fsutil output and fail-closed diagnostics without changing production path validation. * ci: add focused Windows source contract Run a Windows Node 24 contract on non-documentation pull requests while keeping the full capability suite on Linux and macOS. Share the gate through the verifier and Vitest suite manifest, keep the compatibility matrix macOS/Linux, and document the Windows-only boundary.
Upstream e7d809d (MiniMax-AI#303) re-enables a focused Windows CI contract in .github/workflows/ci.yml. This fork cannot push workflow-file changes with the gh OAuth token (no 'workflow' scope), so the fork's CI matrix stays as before and the matching source-sync assertions are kept at the fork's expected shape. scripts/verify.mjs keeps the new 'windows' profile, which fails closed off Windows and is not part of the default full/platform profiles. Restore both files from upstream once the workflow scope restriction is lifted or Windows CI is adopted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commits merged (origin/main ce2116c -> upstream/main ed1f927)
Aucun commit candidat n'ajoute de telemetrie / analytics / phone-home ; aucun ne touche un chemin de
scripts/lib/retired-sources.mjs; aucun doublon de PR deja fusionnee (patch-ids verifies).Conflit resolu
scripts/verify.mjs: conservation du gate forkcheck:egress+ reprise du profilewindowsamont.Commit local de repli (238c375, 10fa3ee, 6626597)
Le workflow amont active
windows-latestdans.github/workflows/ci.yml. Le token OAuth degh(scopes gist/read:org/repo) n'a pas le scopeworkflow, donc GitHub refuse tout push modifiant un fichier de workflow (refusing to allow an OAuth App to create or update workflow ... without workflow scope). Verifie par sonde : tout push touchant.github/workflows/*est rejete, meme un nouveau fichier.Resolution conservatrice : sur cette branche,
ci.ymlettest/source-sync.test.mjsrestent au contenu du fork (matrice ubuntu/macos uniquement, assertions source-sync correspondantes). Le profilewindowsdescripts/verify.mjsest conserve (il echoue ferme hors Windows et n'est pas dans les profils par defaut). A retablir depuis l'amont quand le scopeworkflowsera disponible. Le reste de e7d809d (preflight NTFSscripts/check-windows-source-location.mjs, docs,test/windows-contract.test.mjs, skip WSL sur win32) est merge normalement.Gates (linux-arm64, node 26.5.1)
Tests connus rouges (preexistants, non imputables a ce merge)
packages/tui/test/unit/update-service.test.ts: 8 echecs "Unsupported MCode update host: linux-arm64". Verifie identiques sur un worktree de baselinece2116c(8 failed / 4355 passed) et sur la branche apres merge (8 failed / 4361 passed — +6 tests passes venant des nouveaux commits). Environment : pas de cible linux-arm64 dans le service de mise a jour amont.MiniMax-AI#240 (provider-add token-limits + proxy-audit smoke) est closed (completed) le 2026-09-20 : les suites smoke et byok passent desormais integralement sur cette machine.
Limites de verification
pnpm verifynon lancee en un seul profil (gates lancees individuellement, meme ordre que CI).Addendum (2026-09-22): fork install docs + release process
Commit 85dc4d6 accumulates the documentation work requested in this PR:
filecdn.minimax.chatinstaller and public@minimax-ai/codenpm relabeled as upstream-only channels; build-from-source clone URL points attournierjc/minimax-code.<upstream>-fork.Nversioning scheme, tag-triggeredCLI releaseworkflow reuse,gh pr createREST workaround, prohibitions, upstream-channel table.release/public-source.jsonregenerated (node scripts/source-inventory.mjs --write).Gate status for this commit:
pnpm verify --profile docsPASS (4 gates; docs-only skips listed by the verifier),source-inventoryPASS (4226 files),check:tsconfigPASS,check:standalonePASS,test:release-toolsPASS (40 pass/1 skip),test:artifactPASS.Known-red (unchanged, upstream MiniMax-AI#240 + proxy-audit on node>=24):
test:smoketoken-limits + proxy-audit items.