protocol/chunk: reset chunk encoder state on stream end - #4
Open
urlynn wants to merge 1 commit into
Open
Conversation
The server's per-connection chunk encoder keeps its per-chunk-stream timestamp/format state across sessions. When a publisher disconnects and reconnects on the same downstream connection, the new session's first timestamp (0) is encoded as a delta against the stale high timestamp -> timestamp regression. Reference implementations bind encoder state to the session (ffmpeg rtmp_close frees prev_pkt, SRS builds a fresh SrsProtocol per connection). Add ChunkEncoder::reset() (clears per-stream state, keeps chunk size) and call it from handle_stream_ended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's per-connection chunk encoder keeps its per-chunk-stream timestamp/format state across sessions. When a publisher disconnects and reconnects on the same downstream connection, the new session's first timestamp (0) is encoded as a delta against the stale high timestamp -> timestamp regression. Reference implementations bind encoder state to the session (ffmpeg rtmp_close frees prev_pkt, SRS builds a fresh SrsProtocol per connection).
Add ChunkEncoder::reset() (clears per-stream state, keeps chunk size) and call it from handle_stream_ended.