Repository navigation
Conversation
The web UI's tonie card builds the track download from the tag's audioUrl (/content/download/<ruid>), but only /content/<path> handled tracks=, so the whole TAF was served as Ogg instead of a zip. Resolve the tag's source (e.g. lib://) and use the same track export as /content/. Refs toniebox-reverse-engineering/teddycloud_web#350 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An out-of-range, non-numeric or empty tracks= value made the track export return an error code without sending a response, so the server dropped the connection (a reverse proxy shows this as 502). Answer with 400 on both /content/ and /content/download/ instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An invalid
tracks=value (out of range, non-numeric, or empty, e.g.tracks=9,tracks=abc,tracks=,) made the track export return an error code without sending a response. The server then dropped the connection, and a reverse proxy reports that as 502. This affects both/content/<path>?tracks=…and/content/download/<ruid>?tracks=….Change
handleApiContentTrackExportanswers an invalid track selection with400 Invalid track selection.Tests
tests/py/test_track_export.pycheckstracks=9,tracks=0,tracks=abcandtracks=,on both routes and expects 400. The previous test accepted a dropped connection.Related: toniebox-reverse-engineering/teddycloud_web#350
🤖 Generated with Claude Code