🛡️ Sentinel: [CRITICAL] Fix insecure deserialization in UploadInfo parsing#98
🛡️ Sentinel: [CRITICAL] Fix insecure deserialization in UploadInfo parsing#98tomdesair wants to merge 1 commit into
Conversation
Use ValidatingObjectInputStream from commons-io to enforce an allowlist of classes during deserialization, mitigating a potential Remote Code Execution (RCE) vulnerability. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
coverage: 94.924% (+0.004%) from 94.92% — bugfix/secure-deserialization-2797160734498569469 into master |
2 participants
🚨 Severity: CRITICAL
💡 Vulnerability: Insecure Java Object Deserialization in
Utils.java. It allowed any arbitrary object to be deserialized viaObjectInputStream.🎯 Impact: RCE (Remote Code Execution) if an attacker can manipulate the saved state files.
🔧 Fix: Replaced
ObjectInputStreamwithcommons-io'sValidatingObjectInputStreamand added a strict whitelist for accepted classes (java.lang.*,java.util.*,me.desair.tus.**, arrays).✅ Verification: Ran unit tests to verify no regressions and successfully restricted the classloader.
PR created automatically by Jules for task 2797160734498569469 started by @tomdesair