fix(linebreak): allow Knuth-Plass to place words longer than width - #5
Merged
Conversation
Words longer than the target width could never be assigned a finite cost, leaving minCost stuck at +Inf and collapsing the whole input onto a single line instead of wrapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minCoststuck at+Infand collapsing the entire input onto a single line instead of wrapping.j == i+1) to be costed even when it overflows the width, matchingGreedy's existing behavior of never dropping an overlong word.Test plan
Word longer than widthcase toTestKnuthPlassgo test ./...passes