Skip logical slot processing in PostgreSQL polling mode - #651
Merged
Conversation
toluaina
approved these changes
Aug 28, 2026
toluaina
left a comment
Owner
There was a problem hiding this comment.
Great find. and thanks for adding test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PGSync documents
--pollingas operatinginstead of logical replication
and requiring
only database read access.
However,
Sync.pull(polling=True)still calls logical-slot operations. Ifthe slot is missing or the user lacks replication privileges, the checkpoint
is not updated, causing the same rows—or the full table—to be scanned again
on every cycle.
Solution
After a successful forward pass, PostgreSQL polling mode now stores the
captured
snapshot_xmincheckpoint and returns before accessing the WAL orlogical replication slot.
MySQL/MariaDB and PostgreSQL replication-based modes are unchanged.
Tests
pytest tests/test_sync_polling.py -vv./scripts/lint.sh