Skip to content

test: verify octocov reports a runtime regression - #882

Closed
toiroakr wants to merge 1 commit into
mainfrom
test/octocov-performance-diff
Closed

toiroakr wants to merge 1 commit into
mainfrom
test/octocov-performance-diff

Conversation

@toiroakr

@toiroakr toiroakr commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Disposable verification PR for #881. Do not merge or release.

  • Add a deliberate 0.1 ms synchronous delay to each argument parse, producing a real runtime regression while preserving parsed results.
  • Compare unchanged benchmark workloads against the main report from commit 39f5c42 to verify that octocov publishes timing differences in this PR and the Actions summary.
  • Close this draft after capturing the report.

Build, lint, formatting, type checks, and dependency checks pass. All 564 test files pass (13,271 passed, 639 skipped), with no type errors. Self-review correctly identified the deliberate delay as unsuitable for release; this change exists only in this disposable branch.

Code Metrics Report

main (39f5c42) #882 (773c70e) +/-
Coverage 93.3% 93.3% +0.0%
Test Execution Time 41s 30s -11s
Details
  |                     | main (39f5c42) | #882 (773c70e) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          93.3% |          93.3% | +0.0% |
  |   Files             |            141 |            141 |     0 |
  |   Lines             |           8933 |           8934 |    +1 |
+ |   Covered           |           8340 |           8341 |    +1 |
+ | Test Execution Time |            41s |            30s |  -11s |

Code coverage of files in pull request scope (93.4% → 93.4%, patch 100.0%)

Files Coverage +/- Patch Coverage Status
packages/core/src/parser/argv-parser.ts 93.4% +0.0% 100.0% modified

Runtime performance (lower is better)

main (39f5c42) #882 (773c70e) +/-
Argument parsing 1153.5 ns/op 171833.1 ns/op +170679.6 ns/op
Zod schema extraction (warm cache) 19.2 ns/op 19.2 ns/op -0.1 ns/op
Subcommand execution (Zod) 41800.6 ns/op 255741.3 ns/op +213940.6 ns/op
Help generation 12289.7 ns/op 12208.2 ns/op -81.5 ns/op
bash completion (static) 63073.8 ns/op 59328.1 ns/op -3745.7 ns/op
bash completion (dispatcher) 26740.7 ns/op 26402.3 ns/op -338.5 ns/op
zsh completion (static) 62760.4 ns/op 60389.2 ns/op -2371.2 ns/op
zsh completion (dispatcher) 27958.0 ns/op 28067.2 ns/op +109.1 ns/op
fish completion (static) 52474.1 ns/op 52749.5 ns/op +275.3 ns/op
fish completion (dispatcher) 28693.7 ns/op 28853.7 ns/op +159.9 ns/op
Metadata
main (39f5c42) #882 (773c70e)
Node.js v24.21.0 v24.21.0
Platform linux/x64 linux/x64
sampling 300 ms warmup; median of 7 x 250 ms samples; 100 ops/batch 300 ms warmup; median of 7 x 250 ms samples; 100 ops/batch

Reported by octocov

Copilot AI balanced review requested due to automatic review settings October 8, 2026 00:54
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/politty@2c7fe96
npm i https://pkg.pr.new/@politty/valibot@2c7fe96
npm i https://pkg.pr.new/@politty/zod@2c7fe96
npm i https://pkg.pr.new/@politty/zod-mini@2c7fe96

commit: 2c7fe96

This comment was marked as off-topic.

@toiroakr toiroakr closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants