Skip to content

feat(parse)!: throw only on fatal errors - #116

Merged
tmlmt merged 1 commit into
v3from
feat/throw-only-fatal
Oct 25, 2026
Merged

tmlmt merged 1 commit into
v3from
feat/throw-only-fatal

Conversation

@tmlmt

@tmlmt tmlmt commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Description

Allow parsing to report recoverable errors without throwing; only fatal errors stop parsing.

Related Issue: N/A

Type of change

  •  Breaking change

Breaking Changes

parse() on Recipe, Pantry, ProductCatalog, and CategoryConfig no longer throws for recoverable errors. Check reported diagnostics and error codes instead.

tmlmt commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner Author

tmlmt commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner Author

Merge activity

  • Oct 25, 10:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 25, 10:30 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 25, 10:30 PM UTC: @tmlmt merged this pull request with Graphite.

@tmlmt
tmlmt changed the base branch from test/custom-matcher to graphite-base/116 October 25, 2026 22:27
@tmlmt
tmlmt changed the base branch from graphite-base/116 to v3 October 25, 2026 22:28
BREAKING CHANGE: errors are now reported without exiting the parse() function if they don't compromise the rest of the parsing. See list of error codes for details. This apply to all parse() function i.e. Recipe, Pantry, ProductCatalog and CategoryConfig
@tmlmt
tmlmt force-pushed the feat/throw-only-fatal branch from b9d4580 to f365973 Compare October 25, 2026 22:29
@tmlmt
tmlmt merged commit e033ddb into v3 Oct 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant