Repository navigation
refactor: move the microsim.psf implementation to private microsim._psf - #162
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
===========================================
+ Coverage 67.26% 88.26% +21.00%
===========================================
Files 48 49 +1
Lines 3314 3316 +2
===========================================
+ Hits 2229 2927 +698
+ Misses 1085 389 -696 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure move, no behavior change: the implementation of
microsim.psfnow lives in a privatemicrosim._psf, andmicrosim.psfre-exports the same public names as before (make_psf,make_confocal_psf,cached_psf,vectorial_*...). The first commit is just thegit mv, if you want to check that nothing else changed.This is prep for an upcoming PR that reworks the confocal PSF pipeline (excitation spot computed at the excitation wavelength), which adds a bunch of internal helpers that I don't want to become public API. I'd like to move more of the accidentally-public stuff out of
microsim.psfeventually.