Fix CLI --help safety and @handle card lookup#218
Conversation
|
Someone is attempting to deploy a commit to the Vezures Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR makes two small CLI fixes: dispatchCli's help detection now also triggers on a parsed ChangesCLI Dispatch Fixes
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e862644156
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| parsed.command === "help" || | ||
| parsed.command === "--help" | ||
| parsed.command === "--help" || | ||
| boolFlag(parsed.flags, "help") |
There was a problem hiding this comment.
Preserve forwarded wrapper help arguments
When running the wrapper commands, this global help check fires before the codex/claude dispatch below. Since parseArgs does not treat -- as an option terminator, invocations such as tinyplace codex -- --help or tinyplace claude -- --help now return TinyPlace's own help instead of forwarding --help to the underlying tool, even though the command usage documents arbitrary <codex-args...> / <claude-args...> after --.
Useful? React with 👍 / 👎.
Summary
--helpbefore context creation and dispatch, so mutation commands cannot execute when help is requested@handleto cryptoId beforeraw card/ barecardGraphQL lookupLinked issues
Fixes part of #216.
Addresses #217.
Verification
corepack pnpm --filter @tinyhumansai/tinyplace lintandcorepack pnpm --dir sdk/typescript exec tsc --noEmitwere blocked by pnpm's build-script approval gate (ERR_PNPM_IGNORED_BUILDS).resolveAgentIdhelper.Summary by CodeRabbit