ci(homebrew): wait for release assets before bumping the formula - #49
Merged
Conversation
The v0.2.0 release exposed a race: homebrew.yml and release-binaries.yml both fire on 'release: published' (now that release-plz uses a PAT and releases trigger workflows), but the formula bump needs the tarballs that release-binaries produces. Homebrew ran first and failed with 'no assets to download'; the bump then had to be triggered by hand. Adds a step that polls the release for all three tarballs (up to ~15 minutes, matching the ~5-minute multi-runner build) before computing checksums. Decoupled from release-binaries' timing rather than chained to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race the v0.2.0 release exposed.
What happened
Now that release-plz uses a PAT (#43), a release fires its downstream workflows automatically — confirmed working on v0.2.0:
release-binaries.ymlauto-ran and built all five artifacts. Buthomebrew.ymlalso fires onrelease: published, at the same time, and the formula bump needs the tarballs thatrelease-binaries.ymlis still building:So the Homebrew bump had to be triggered by hand for v0.2.0 (done — the tap is on 0.2.0).
Fix
A step that polls the release for all three tarballs (up to ~15 minutes, matching the ~5-minute multi-runner build) before computing checksums. Decoupled from
release-binaries.yml's timing rather than chained to it, so either can be re-run independently.With this, the next release needs no manual Homebrew trigger — the full pipeline (crates.io → binaries/.deb → tap) runs end to end on its own.