New plot_capture_zone function#145
Conversation
|
This should fixe #134, but also needs to implement: |
|
@dbrakenhoff, I get an error that |
|
I think I fixed this in one of the other PRs (#135 I think). I removed the newfig anyway, which we don't need anymore since we use the axes for everything now. |
|
@dbrakenhoff I tried to merge dev into this branch, but now I get really strange errors when running the tests. Any thoughts? Maybe merge back and try again? |
|
The kernel name in the 00_single layrr notebook and maybe others is not recognized. My guess is running |
|
That worked. Thanks! |
|
I think updated the clear notebooks script in one of the other PRs to not touch the pumping test notebooks. It might be that emptying the pumping test notebooks will cause the docs to time out. |
dbrakenhoff
left a comment
There was a problem hiding this comment.
Looks good! Only thing is those changes to the pumping test notebooks.
|
And I pointed it to dev. |
The new
plot_capture_zonefunction does the same at the oldplotcapzonefunction, but doesn't have the metadata keyword anymore (that was already removed from the traceline functions. And it has a better name.We could think whether it should be
plot_capture_zonesinstead, as a list of wells can be specified. Then again, in case of a list of wells, I wonder if it should not also accept a list or array of zstart values. So maybe just leave it atplot_capture_zone.