Skip to content

New plot_capture_zone function#145

Merged
mbakker7 merged 11 commits into
devfrom
plot_capture_zone
Jun 19, 2026
Merged

New plot_capture_zone function#145
mbakker7 merged 11 commits into
devfrom
plot_capture_zone

Conversation

@mbakker7

Copy link
Copy Markdown
Contributor

The new plot_capture_zone function does the same at the old plotcapzone function, but doesn't have the metadata keyword anymore (that was already removed from the traceline functions. And it has a better name.

We could think whether it should be plot_capture_zones instead, as a list of wells can be specified. Then again, in case of a list of wells, I wonder if it should not also accept a list or array of zstart values. So maybe just leave it at plot_capture_zone.

@mbakker7 mbakker7 marked this pull request as draft June 18, 2026 19:42
@mbakker7

Copy link
Copy Markdown
Contributor Author

This should fixe #134, but also needs to implement:
By default throw a warning if one or more pathlines have not reached the desired tmax within the maximum number of time steps with a warning: 'XX pathlines did not reach the specified tmax before reaching the maximum number nstepmax of steps' (where XX is the number of pathlines).

@mbakker7

Copy link
Copy Markdown
Contributor Author

@dbrakenhoff, I get an error that QuadContourSet.set() got an unexpected keyword argument 'newfig'.
This comes from the contour_array array in steady.plots. But only in the Python 3.13 tests, so it may be that matplotlib dropped the newfig keyword?

@dbrakenhoff

Copy link
Copy Markdown
Contributor

I think I fixed this in one of the other PRs (#135 I think). I removed the newfig anyway, which we don't need anymore since we use the axes for everything now.

@mbakker7

Copy link
Copy Markdown
Contributor Author

@dbrakenhoff I tried to merge dev into this branch, but now I get really strange errors when running the tests. Any thoughts? Maybe merge back and try again?

@dbrakenhoff

Copy link
Copy Markdown
Contributor

The kernel name in the 00_single layrr notebook and maybe others is not recognized. My guess is running python utils/clear_notebooks.py might fix it?

@mbakker7

Copy link
Copy Markdown
Contributor Author

That worked. Thanks!

@dbrakenhoff

Copy link
Copy Markdown
Contributor

I think updated the clear notebooks script in one of the other PRs to not touch the pumping test notebooks. It might be that emptying the pumping test notebooks will cause the docs to time out.

@mbakker7 mbakker7 marked this pull request as ready for review June 19, 2026 12:48
@mbakker7 mbakker7 requested a review from dbrakenhoff June 19, 2026 12:48

@dbrakenhoff dbrakenhoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing is those changes to the pumping test notebooks.

@dbrakenhoff dbrakenhoff changed the base branch from main to dev June 19, 2026 13:05
@dbrakenhoff

Copy link
Copy Markdown
Contributor

And I pointed it to dev.

@mbakker7 mbakker7 merged commit dc88e91 into dev Jun 19, 2026
11 checks passed
@mbakker7 mbakker7 deleted the plot_capture_zone branch June 19, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants