Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to tile-ai/tilelang#2948 and tile-ai/tilelang#3090.
Root cause
VisitExpr_(AddNode) stores the offset in IterSumExpr::base. SplitFloorModConst computes that phase as pair.second, but the bijective path has no padded IterMark carrying it and returns only pair.first. The resulting normalized map is therefore semantically different:
InverseAffineIterMap then sees an unshifted split and produces x = output.
Validation
Before the fix, the regression test failed because the cyclic shift produced one accepted bijective index.
After the fix:
The repository-wide ASF-header pre-commit hook reports 11 pre-existing missing headers outside this change; all relevant formatting and lint hooks pass.