fix(deps): pin mcp to v1 — v2 renamed FastMCP and breaks the import - #64
Open
tikankika wants to merge 1 commit into
Open
fix(deps): pin mcp to v1 — v2 renamed FastMCP and breaks the import#64tikankika wants to merge 1 commit into
tikankika wants to merge 1 commit into
Conversation
mcp 2.x renames FastMCP to MCPServer, so `from mcp.server.fastmcp import FastMCP` fails outright on a fresh resolve. The old floor (>=1.0.0) let that happen. Pin to >=1.28.1,<2 and lock mcp 1.29.0. The upper bound is the load-bearing half; the raised floor just matches what the lock already resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vad
mcp>=1.0.0→mcp>=1.28.1,<2ipackages/qf-pipeline/pyproject.toml, med uv.lock uppdaterad (mcp 1.25.0 → 1.29.0).Varför
mcp 2.x döper om
FastMCPtillMCPServer. Med den gamla golvspecen>=1.0.0kan en färsk resolve dra in 2.x, och då failarfrom mcp.server.fastmcp import FastMCPdirekt vid import — inte vid något kantfall, utan på första raden.Övre gränsen är den bärande halvan. Det höjda golvet speglar bara vad låsfilen redan löste ut.
Samma problem finns okorrigerat i ACDM, där testsviten inte ens kollekterar mot en installerad 2.x. Det åtgärdas separat.
Test
uv run --frozen pytest -qipackages/qf-pipeline: 61 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01KHXjsZxr2d8Mi8WVMqyfEq