Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tibble_quos()in R/tibble.R copies.rowsintofirst_sizewithout checking it. The first evaluated column then hitsfirst_size == 1L && current_size != 1L, so a vector.rowsfails inside&&with a base R message, and other bad values surface as errors about something else:This PR validates
.rowsonce, before the column loop. It must beNULLor a single non-negative whole number. Anything else goes through a newabort_bad_rows_arg()helper that follows the existingtibble_abort(problems(...))pattern, so the condition gets the classtibble_error_bad_rows_arg.All three calls now fail the same way, with the offending value on the second line:
Found during my most recent ry audit.