Repository navigation
For Eigen 5.0.* use Eigen::Map<Eigen::SparseMatrix>> - #205
Open
eddelbuettel wants to merge 1 commit into
Open
eddelbuettel wants to merge 1 commit into
eddelbuettel wants to merge 1 commit into
Conversation
18 of 43 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi lime team,
Eigen 5.0.0, which we are trying to bring to CRAN in an updated RcppEigen, did away with Eigen::MappedSparseMatrix. (Also note that they changed the versioning scheme so Eigen 5.0.0 corresponds to 3.5.0 under the old scheme.) See RcppEigen issue 151 for all the changes related to this upgrade.
For MappedSparseMatrix, a change to Map works. Given your careful design, this affects only one line with the corresponding
typedef.With the changes, the package builds against CRAN RcppEigen 0.3.4.0.2 and the release candidate 0.4.9.9-2.
So if you could apply this PR and get the update to CRAN before we update, a new RcppEigen would not break your package. If you don't update it we would get breakage 😞 but this PR overcomes this. We have been at this update for a long time as there were other issues in affected packages so the upload is not really imminent -- but getting closer. If you can get this to CRAN over the next few weeks we would appreciate it. 'Some time' in the near future will work, you can see at RcppEigen issue 151 how the other changes come in.
Thanks!