[SCAL-323294] changes for search_objects and added terminologies by saharsh-ts · Pull Request #178 · thoughtspot/mcp-server

saharsh-ts · 2026-07-09T15:42:19Z

No description provided.

gemini-code-assist

Code Review

This pull request introduces a new search_objects tool to the MCP server, allowing users to search for answers, liveboards, worksheets, and other metadata in ThoughtSpot. The implementation includes GraphQL query definitions, terminology mapping for synonyms, client-side post-filtering, parallel multi-term search merging, and comprehensive unit tests. During the review, a critical issue was identified in the Ping tool handler where the asynchronous validateConnection() method is not awaited, which would cause the connection check to always evaluate as truthy.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

mouryabalabhadra · 2026-07-15T08:35:16Z

@copilot please review

Copilot · 2026-07-15T08:39:05Z

@copilot please review

Reviewed the changes. All 676 tests pass and lint is clean.

src/thoughtspot/terminology.ts

Single-source-of-truth glossary with derived OBJECT_TYPE_FACET_MAP is clean and well-tested (100% coverage).
resolveObjectTypeFacet correctly trims and lowercases before lookup and falls back gracefully for unknown types.

src/thoughtspot/grpc/search_objects/

GraphQL query (search-objects-query.ts) is trimmed to only the fields the mapper reads.
buildFrameUrl correctly handles PINBOARD_VIZ_RESULT by routing parentId (Liveboard) and id (viz) into the right URL segments.
toEpochMs normalization (seconds → ms when value < 1e12) is a sensible heuristic for the Eureka quirk.
Post-filter pagination loop caps at MAX_PAGES = 20 to prevent runaway upstream calls; the warn log on cap is helpful.
mergeTermResults round-robin interleave with per-id confidence dedup is correct (Map preserves first-seen order on set of an existing key, so position is stable).

src/servers/tool-definitions.ts / mcp-server.ts

SearchObjectsInputSchema validation (union of z.string().min(1) and z.array(z.string().min(1)).nonempty()) guards against empty queries before they reach the backend.
Error surfacing in callSearchObjects correctly propagates the upstream message so failures are actionable.

No issues to flag. LGTM.

Rifdhan · 2026-07-17T00:59:35Z

+	query: z
+		.union([z.string().min(1), z.array(z.string().min(1)).nonempty()])
+		.describe(
+			"The search term(s) to find objects for, matched against object names or descriptions. Pass a single string for one search, or an array of distinct terms when the user's request covers several separate things. Each term is searched in parallel and the results are merged and de-duplicated. Note: pagination via `cursor` only applies to a single-term search.",


Is there a prominent need to support multiple disjoint search terms? I feel a single search term will be the 95% case and would prefer simplifying the contract to keep it simple for agent understanding. Especially since some features (eg cursor) won't work in that mode, it can lead to more problems.

supporting only single search term/string (can be multi-word, e.g. "sales by region")

Rifdhan · 2026-07-17T01:01:18Z

+		.describe(
+			"Restrict results to these object types. Accepts friendly and legacy names: 'liveboard' (aliases 'pinboard', 'dashboard'), 'answer', and 'worksheet' (aliases 'logical table', 'data model', 'data source'). Omit to search all types.",
+		),
+	owner: z


Should we call the field author_name instead of owner

Rifdhan · 2026-07-17T01:01:43Z

+		.string()
+		.optional()
+		.describe(
+			"Restrict results to objects authored by this user, matched against the author's display name (case-insensitive).",


Nit: prefer "authored by the provided user" rather than "authored by this user" to avoid confusing with the end user themself

Rifdhan · 2026-07-17T01:07:04Z

+});
+
+const SearchObjectHeaderSchema = z.object({
+	id: z


Let's call it object_id for consistency

Rifdhan · 2026-07-17T01:11:02Z

+		.describe(
+			"Set only when this result is a specific visualization on a Liveboard: `id` is the Liveboard and this is the visualization. Pass it to fetch_data as `visualization_ids` to fetch just this viz.",
+		),
+	name: z.string().describe("The display name/title of the object."),


Let's call it title for consistency with other schemas

Rifdhan · 2026-07-17T01:54:56Z

+
+// Standard headers for ThoughtSpot HTTP calls. `acceptLanguage` is opt-in: the
+// gRPC/Eureka endpoints 500 without it, but the legacy calls never sent it.
+export function buildTsHeaders(


This is duplicate, use buildHeaders existing util and extend if needed

Rifdhan · 2026-07-17T01:55:52Z

+export const TERMINOLOGY: TerminologyEntry[] = [
+	{
+		canonical: "Liveboard",
+		synonyms: ["pinboard", "dashboard", "board"],


Why is canonical capitalized but synonyms are not? Should we make it consistent

updated in object-types.ts

Rifdhan · 2026-07-23T00:00:19Z

+			});
+
+			// no_results and error are returned as structured content (not a
+			// protocol error) so the model gets the typed envelope to render.


What does "typed envelope to render" mean? This comment is a bit unclear to me.

simplified it. it was basically to say that no_results/error are returned as normal structured content (not an MCP protocol error) so the client still gets the structured response.

Rifdhan · 2026-07-23T00:03:25Z

+	description: z
+		.string()
+		.nullable()
+		.describe("The description of the object, or null when it has none."),


Prefer to make this optional and omit if not present, rather than nullable. This is how we handle other fields in other places.

description is optional now, omitted when absent.

Rifdhan · 2026-07-23T00:03:36Z

+		.string()
+		.nullable()
+		.describe(
+			"ISO-8601 timestamp of the last modification (e.g. 2026-05-15T14:30:00Z), or null when unavailable. Render as a plain date.",


same, last_modified optional/omitted.

Rifdhan · 2026-07-23T00:04:17Z

+	verified: z.boolean().describe("Whether the object is marked as verified."),
+	frame_url: z
+		.string()
+		.describe("Deep link to open the object in the ThoughtSpot UI."),


Got it, prefer to call this field something like external_link

Rifdhan · 2026-07-23T00:06:33Z

+		.string()
+		.optional()
+		.describe(
+			"Present on no_results: human-readable 'nothing matched' note; safe to relay to the user.",


Why do we need this? The host agent can display a reasonable no results message themselves.

dropped the no-results message; the host agent renders its own.

Rifdhan · 2026-07-23T00:07:04Z

+	request_id: z
+		.string()
+		.describe(
+			"Correlation id sent on the upstream call as x-request-id; trace this in ThoughtSpot's server logs.",


Let's remove it, we want to minimize the tool schema surface area as much as possible

Rifdhan · 2026-07-23T00:21:09Z

+} from "./search-objects-types";
+
+// Build a deep link to the object in the ThoughtSpot UI from its result type.
+function buildFrameUrl(


We have inconsistent naming for utils in this file, eg "buildFrameUrl", "toEpochMs", "deriveQuery". Let's use a conistent verb if possible.

consistent to* naming, moved to a mapper module.

Rifdhan · 2026-07-23T00:23:22Z

+			facetSelections.push({ facetType: "IS_VERIFIED", facetValue: ["true"] });
+		}
+
+		const endpoint = "/prism/?op=GetEurekaResults";


Inline this

Rifdhan · 2026-07-23T00:24:54Z

+				);
+
+			if (owner) {
+				const needle = owner.toLowerCase();


What does needle mean?

Renamed - it's the lower-cased substring for the post-filter match; now ownerLower/tagLower.

saharsh-ts added 2 commits July 9, 2026 11:52

[SCAL-319676] terminologies added

d7f8fbd

[SCAL-323294] changes for search_objects tool

57e354a

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread src/servers/mcp-server.ts Outdated

[SCAL-323294] merge main and resolve conflicts

9396681

Copilot started work on behalf of mouryabalabhadra July 15, 2026 08:35 View session

Copilot finished work on behalf of mouryabalabhadra July 15, 2026 08:39

Copilot AI requested a review from mouryabalabhadra July 15, 2026 08:39

Rifdhan reviewed Jul 17, 2026

View reviewed changes

[SCAL-323294] added schema for search_objects response format

959eeed

saharsh-ts force-pushed the SCAL-323294_search-objects branch from 22b6428 to 959eeed Compare July 20, 2026 09:47

[SCAL-323294] refactoring and updates to search-objects tool

09bd735

Rifdhan reviewed Jul 23, 2026

View reviewed changes

saharsh-ts added 3 commits July 24, 2026 14:00

[SCAL-323294] added schema check for searhc_objects, and refactored

7fd9463

[SCAL-323294] added constants file

2d5c7f3

[SCAL-323294] removed schema check query

a16a949

Uh oh!

Conversation

saharsh-ts commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

mouryabalabhadra commented Jul 15, 2026

Uh oh!

Copilot AI commented Jul 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saharsh-ts Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saharsh-ts Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saharsh-ts Jul 22, 2026 •

edited

Loading

saharsh-ts Jul 24, 2026 •

edited

Loading