fix: source_events_per_minute=0 must block all events, not disable th… - #23
Open
manishmcsa01-cmd wants to merge 1 commit into
Open
manishmcsa01-cmd wants to merge 1 commit into
manishmcsa01-cmd wants to merge 1 commit into
Conversation
…e limit
Bug: In AutonomyGovernor.admit_event(), the guard:
if self.source_events_per_minute > 0:
skips the rate limit entirely when the value is 0. An operator setting
source_events_per_minute=0 intends 'block all events from any source',
but actually gets 'allow unlimited events' -- the control does not hold.
This is exactly the kind of bug the session warns about: a ceiling that
resets to infinity at the boundary value.
Fix: Change the guard to >= 0 and handle the zero case explicitly by
refusing immediately with a clear reason.
Test: test_zero_source_rate_limit_blocks_all_events fails before this
change (verdict.admitted is True) and passes after (admitted is False).
Owner
Session 16 — graded ✅Score: +100.
|
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e limit
Bug: In AutonomyGovernor.admit_event(), the guard:
if self.source_events_per_minute > 0:
skips the rate limit entirely when the value is 0. An operator setting source_events_per_minute=0 intends 'block all events from any source', but actually gets 'allow unlimited events' -- the control does not hold.
This is exactly the kind of bug the session warns about: a ceiling that resets to infinity at the boundary value.
Fix: Change the guard to >= 0 and handle the zero case explicitly by refusing immediately with a clear reason.
Test: test_zero_source_rate_limit_blocks_all_events fails before this change (verdict.admitted is True) and passes after (admitted is False).